Re: [PATCH 1/1] media: dvb_dummy_tuner: implement driver skeleton

Mauro Carvalho Chehab
2020-01-09T16:14:08Z

Em Thu, 9 Jan 2020 12:24:08 -0300
"Daniel W. S. Almeida" <dwlsalmeida@gmail.com> escreveu:

> From: "Daniel W. S. Almeida" <dwlsalmeida@gmail.com>
>
> Implement the skeleton for the tuner driver in a separate file.
>
> Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
> ---
> drivers/media/tuners/Kconfig | 7 ++
> drivers/media/tuners/Makefile | 1 +
> drivers/media/tuners/dvb_dummy_tuner.c | 153 +++++++++++++++++++++++++
> drivers/media/tuners/dvb_dummy_tuner.h | 20 ++++
> 4 files changed, 181 insertions(+)
> create mode 100644 drivers/media/tuners/dvb_dummy_tuner.c
> create mode 100644 drivers/media/tuners/dvb_dummy_tuner.h
>
> diff --git a/drivers/media/tuners/Kconfig b/drivers/media/tuners/Kconfig
> index e104bb7766e1..efa1591fe0ae 100644
> --- a/drivers/media/tuners/Kconfig
> +++ b/drivers/media/tuners/Kconfig
> @@ -296,4 +296,11 @@ config MEDIA_TUNER_QM1D1B0004
> default m if !MEDIA_SUBDRV_AUTOSELECT
> help
> Sharp QM1D1B0004 ISDB-S tuner driver.
> +
> +config MEDIA_TUNER_DVB_DUMMY_TUNER
> + tristate "Dummy tuner"
> + depends on MEDIA_SUPPORT && I2C

> + default m if !MEDIA_SUBDRV_AUTOSELECT

Actually, this is a dummy driver. It should not be auto-selected, as no
real hardware depends on it. We don't want production distros to come with
those test drivers.

When we add a bridge driver (let's say we call it DVB_DUMMY_BRIDGE), then
what we could do here would be something like:

depends on DVB_DUMMY_BRIDGE
default y

Cheers,
Mauro