From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3032C33CA2 for ; Fri, 10 Jan 2020 00:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F6BC2077C for ; Fri, 10 Jan 2020 00:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578615086; bh=/ursooGYobJkHxZh7joDxwx6+SWWdJcogy33Ye/MQ8g=; h=From:In-Reply-To:References:Cc:Subject:Date:To:List-ID:From; b=duZLBdtPbd6CCcgLUMTD8dGgpF+Qtqdvx+GhpRGSOh7mb7XwXo39IJrxJ7XQfU54A fVF3QpIhDpGnKOMDVGCOYLLU9uxNC9XWTMPK1J6MNmBIBb093V5Dw7sCeQoQIeC540 jwVFubPInxKfi2mAWAbZmIdT2W34FpFk3lZTxMSY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730138AbgAJALZ (ORCPT ); Thu, 9 Jan 2020 19:11:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:32828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730001AbgAJALZ (ORCPT ); Thu, 9 Jan 2020 19:11:25 -0500 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8B82B20661; Fri, 10 Jan 2020 00:11:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578615084; bh=/ursooGYobJkHxZh7joDxwx6+SWWdJcogy33Ye/MQ8g=; h=From:In-Reply-To:References:Cc:Subject:Date:From; b=q+ZN5qWpafDiIwKpQU8BWxj7PSnxNvUbCSyFQglYSdcCaJtx6SCTMK8XA0XpspjQV fTTYHGTMWkcvCvzVWuxl8ywNBOWExTAMmbMS+OMVRyn8Cn1v8/Avp32kyLp1MwK3ND L7eR8JRe1ENLYDp7ILOc53pbewMIybmhsAZU4CuQ= From: sboyd@kernel.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20200109214128.GB1027187@piout.net> References: <20191229202907.335931-1-alexandre.belloni@bootlin.com> <20200106030905.8643221582@mail.kernel.org> <20200108110218.GT3040@piout.net> <20200109181910.59B2B206ED@mail.kernel.org> <20200109214128.GB1027187@piout.net> Cc: Nicolas Ferre , Michael Turquette , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: at91: add sama5d3 pmc driver User-Agent: alot/0.8.1 Date: Thu, 09 Jan 2020 16:11:23 -0800 Message-Id: <20200110001124.8B82B20661@mail.kernel.org> To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Boyd Quoting Alexandre Belloni (2020-01-09 13:41:28) > On 09/01/2020 10:19:09-0800, Stephen Boyd wrote: > > Quoting Alexandre Belloni (2020-01-08 03:02:18) > > >=20 > > > As for the other PMC driver, we need a few of the peripheral clocks v= ery > > > early which means that we would have to register most of the clock tr= ee > > > registered early leaving only a few clocks to be registered by a > > > platform driver. > > >=20 > >=20 > > What peripheral clks? Can you add a comment to the code? > >=20 >=20 > The TCB is used as the clocksource so its clock is needed. Its parent is > the master clock which has UTMI, PLLA, the mainclock and the slow clock > as parents so by that point, most of the tree is registered. >=20 What in sama5d3_periphck[] is in that list? I still don't see why platform device is rejected here.