* [PATCH] bus: tegra-aconnect: remove PM_CLK dependency
@ 2019-06-20 15:51 Sameer Pujar
2019-06-20 16:02 ` Jon Hunter
0 siblings, 1 reply; 3+ messages in thread
From: Sameer Pujar @ 2019-06-20 15:51 UTC (permalink / raw)
To: thierry.reding, jonathanh; +Cc: linux-tegra, linux-kernel, Sameer Pujar
aconnect bus driver does not use pm-clk interface now and hence the
dependency is removed from Kconfig.
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
drivers/bus/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
index 1851112..4587ef2 100644
--- a/drivers/bus/Kconfig
+++ b/drivers/bus/Kconfig
@@ -128,7 +128,6 @@ config TEGRA_ACONNECT
tristate "Tegra ACONNECT Bus Driver"
depends on ARCH_TEGRA_210_SOC
depends on OF && PM
- select PM_CLK
help
Driver for the Tegra ACONNECT bus which is used to interface with
the devices inside the Audio Processing Engine (APE) for Tegra210.
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency
2019-06-20 15:51 [PATCH] bus: tegra-aconnect: remove PM_CLK dependency Sameer Pujar
@ 2019-06-20 16:02 ` Jon Hunter
2020-01-10 11:32 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Jon Hunter @ 2019-06-20 16:02 UTC (permalink / raw)
To: Sameer Pujar, thierry.reding; +Cc: linux-tegra, linux-kernel
On 20/06/2019 16:51, Sameer Pujar wrote:
> aconnect bus driver does not use pm-clk interface now and hence the
> dependency is removed from Kconfig.
>
> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> ---
> drivers/bus/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> index 1851112..4587ef2 100644
> --- a/drivers/bus/Kconfig
> +++ b/drivers/bus/Kconfig
> @@ -128,7 +128,6 @@ config TEGRA_ACONNECT
> tristate "Tegra ACONNECT Bus Driver"
> depends on ARCH_TEGRA_210_SOC
> depends on OF && PM
> - select PM_CLK
> help
> Driver for the Tegra ACONNECT bus which is used to interface with
> the devices inside the Audio Processing Engine (APE) for Tegra210.
Thanks. We should probably populate the 'Fixes:' tag for this to show
which commit this fixes. Otherwise ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bus: tegra-aconnect: remove PM_CLK dependency
2019-06-20 16:02 ` Jon Hunter
@ 2020-01-10 11:32 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2020-01-10 11:32 UTC (permalink / raw)
To: Jon Hunter; +Cc: Sameer Pujar, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1280 bytes --]
On Thu, Jun 20, 2019 at 05:02:27PM +0100, Jon Hunter wrote:
>
> On 20/06/2019 16:51, Sameer Pujar wrote:
> > aconnect bus driver does not use pm-clk interface now and hence the
> > dependency is removed from Kconfig.
> >
> > Signed-off-by: Sameer Pujar <spujar@nvidia.com>
> > ---
> > drivers/bus/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/bus/Kconfig b/drivers/bus/Kconfig
> > index 1851112..4587ef2 100644
> > --- a/drivers/bus/Kconfig
> > +++ b/drivers/bus/Kconfig
> > @@ -128,7 +128,6 @@ config TEGRA_ACONNECT
> > tristate "Tegra ACONNECT Bus Driver"
> > depends on ARCH_TEGRA_210_SOC
> > depends on OF && PM
> > - select PM_CLK
> > help
> > Driver for the Tegra ACONNECT bus which is used to interface with
> > the devices inside the Audio Processing Engine (APE) for Tegra210.
>
> Thanks. We should probably populate the 'Fixes:' tag for this to show
> which commit this fixes. Otherwise ...
>
> Acked-by: Jon Hunter <jonathanh@nvidia.com>
Looks like this was never applied. I don't recollect that there was a
specific reason why we shouldn't, so I went ahead and applied this after
adding:
Fixes: 0d7dab926130 ("bus: tegra-aconnect: use devm_clk_*() helpers")
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-01-10 11:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-20 15:51 [PATCH] bus: tegra-aconnect: remove PM_CLK dependency Sameer Pujar
2019-06-20 16:02 ` Jon Hunter
2020-01-10 11:32 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox