From: Greg KH <greg@kroah.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Garrett <mjg59@google.com>,
bugzilla@colorremedies.com
Subject: Re: [PATCH 3/3] tracing: Do not create directories if lockdown is in affect
Date: Fri, 10 Jan 2020 17:54:04 +0100 [thread overview]
Message-ID: <20200110165404.GA1837739@kroah.com> (raw)
In-Reply-To: <20200110163105.GA17434@home.goodmis.org>
On Fri, Jan 10, 2020 at 11:31:05AM -0500, Steven Rostedt wrote:
> I should have marked this for stable. The commit it fixes (see Fixes tag) is
> in 5.4, and it appears this has yet to make it to 5.4 yet.
>
> -- Steve
>
>
> On Wed, Dec 04, 2019 at 09:05:02PM -0500, Steven Rostedt wrote:
> > From: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> >
> > If lockdown is disabling tracing on boot up, it prevents the tracing files
> > from even bering created. But when that happens, there's several places that
> > will give a warning that the files were not created as that is usually a
> > sign of a bug.
> >
> > Add in strategic locations where a check is made to see if tracing is
> > disabled by lockdown, and if it is, do not go further, and fail silently
> > (but print that tracing is disabled by lockdown, without doing a WARN_ON()).
> >
> > Cc: Matthew Garrett <mjg59@google.com>
> > Fixes: 17911ff38aa5 ("tracing: Add locked_down checks to the open calls of files created for tracefs")
> > Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Relying only on the Fixes: tag to get things picked up by stable is a
sure way to get it on the "slow, and maybe eventually, hopefully, it
might make it into stable" path :)
I have over 1000 patches right now in that "bucket" that need to be
checked to see if they are relevant for stable backporting, just since
5.4 was released. I have automated a lot of it, but still, they require
manual review.
I'll go queue this up now, as it's simplest just to ask us to take it
after it hits Linus's tree :)
thanks,
greg k-h
next prev parent reply other threads:[~2020-01-10 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-05 2:04 [PATCH 0/3] [GIT PULL] tracing: three more updates Steven Rostedt
2019-12-05 2:05 ` [PATCH 1/3] tracing: Fix __print_hex_dump scope Steven Rostedt
2019-12-05 2:05 ` [PATCH 2/3] tracing: Introduce trace event injection Steven Rostedt
2019-12-05 2:05 ` [PATCH 3/3] tracing: Do not create directories if lockdown is in affect Steven Rostedt
2020-01-10 16:31 ` Steven Rostedt
2020-01-10 16:54 ` Greg KH [this message]
2020-01-10 17:02 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110165404.GA1837739@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=bugzilla@colorremedies.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mjg59@google.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox