From: Bean Huo <huobean@gmail.com>
To: alim.akhtar@samsung.com, avri.altman@wdc.com,
pedrom.sousa@synopsys.com, jejb@linux.ibm.com,
martin.petersen@oracle.com, stanley.chu@mediatek.com,
beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
cang@codeaurora.org
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] scsi: ufs: initialize max_lu_supported while booting
Date: Fri, 10 Jan 2020 19:36:05 +0100 [thread overview]
Message-ID: <20200110183606.10102-3-huobean@gmail.com> (raw)
In-Reply-To: <20200110183606.10102-1-huobean@gmail.com>
From: Bean Huo <beanhuo@micron.com>
This patch is to add a new function ufshcd_init_device_param() for
initialization of UFS device related parameters which are used by
driver. In this version patch, there is only dev_info.max_lu_supported
being initialized.
Signed-off-by: Bean Huo <beanhuo@micron.com>
---
drivers/scsi/ufs/ufshcd.c | 47 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 46 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1b97f2dc0b63..a297fe55e36a 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -3158,6 +3158,11 @@ static int ufshcd_read_device_desc(struct ufs_hba *hba, u8 *buf, u32 size)
return ufshcd_read_desc(hba, QUERY_DESC_IDN_DEVICE, 0, buf, size);
}
+static int ufshcd_read_geometry_desc(struct ufs_hba *hba, u8 *buf, u32 size)
+{
+ return ufshcd_read_desc(hba, QUERY_DESC_IDN_GEOMETRY, 0, buf, size);
+}
+
/**
* struct uc_string_id - unicode string
*
@@ -6827,6 +6832,37 @@ static void ufshcd_clear_dbg_ufs_stats(struct ufs_hba *hba)
hba->req_abort_count = 0;
}
+static int ufshcd_init_device_param(struct ufs_hba *hba)
+{
+ int err;
+ size_t buff_len;
+ u8 *desc_buf;
+
+ buff_len = QUERY_DESC_MAX_SIZE;
+ desc_buf = kmalloc(buff_len, GFP_KERNEL);
+ if (!desc_buf) {
+ err = -ENOMEM;
+ goto out;
+ }
+
+ err = ufshcd_read_geometry_desc(hba, desc_buf,
+ hba->desc_size.geom_desc);
+ if (err) {
+ dev_err(hba->dev, "%s: Failed reading Geometry Desc. err = %d\n",
+ __func__, err);
+ goto out;
+ }
+
+ if (desc_buf[GEOMETRY_DESC_PARAM_MAX_NUM_LUN] == 1)
+ hba->dev_info.max_lu_supported = 32;
+ else if (desc_buf[GEOMETRY_DESC_PARAM_MAX_NUM_LUN] == 0)
+ hba->dev_info.max_lu_supported = 8;
+
+out:
+ kfree(desc_buf);
+ return err;
+}
+
static void ufshcd_init_desc_sizes(struct ufs_hba *hba)
{
int err;
@@ -7016,13 +7052,22 @@ static int ufshcd_probe_hba(struct ufs_hba *hba)
/*
* If we are in error handling context or in power management callbacks
- * context, no need to scan the host
+ * context, no need to scan the host and to reinitialize the parameters
*/
if (!ufshcd_eh_in_progress(hba) && !hba->pm_op_in_progress) {
bool flag;
/* clear any previous UFS device information */
memset(&hba->dev_info, 0, sizeof(hba->dev_info));
+ /* Init parameters according to UFS relevant descriptors */
+ ret = ufshcd_init_device_param(hba);
+ if (ret) {
+ dev_err(hba->dev,
+ "%s: Init of device param failed. err = %d\n",
+ __func__, ret);
+ goto out;
+ }
+
if (!ufshcd_query_flag_retry(hba, UPIU_QUERY_OPCODE_READ_FLAG,
QUERY_FLAG_IDN_PWR_ON_WPE, &flag))
hba->dev_info.f_power_on_wp_en = flag;
--
2.17.1
next prev parent reply other threads:[~2020-01-10 18:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 18:36 [PATCH v1 0/3] use UFS device indicated maximum LU number Bean Huo
2020-01-10 18:36 ` [PATCH 1/3] scsi: ufs: add max_lu_supported in struct ufs_dev_info Bean Huo
2020-01-11 22:43 ` Bart Van Assche
2020-01-13 18:43 ` asutoshd
2020-01-10 18:36 ` Bean Huo [this message]
2020-01-11 22:42 ` [PATCH 2/3] scsi: ufs: initialize max_lu_supported while booting Bart Van Assche
2020-01-12 8:41 ` Avri Altman
2020-01-12 9:52 ` [EXT] " Bean Huo (beanhuo)
2020-01-13 18:44 ` asutoshd
2020-01-10 18:36 ` [PATCH 3/3] scsi: ufs: use UFS device indicated maximum LU number Bean Huo
2020-01-11 22:50 ` Bart Van Assche
2020-01-13 18:45 ` asutoshd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200110183606.10102-3-huobean@gmail.com \
--to=huobean@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pedrom.sousa@synopsys.com \
--cc=stanley.chu@mediatek.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox