From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF95C33C9E for ; Sat, 11 Jan 2020 10:23:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 06EA820880 for ; Sat, 11 Jan 2020 10:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578738208; bh=1TsBAZt0kGZestdFokrITKiGHIC4EGqDGcbQA7U+5uU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FnMr1LYA/81zDQgxVZ55naldQEPIr2E7PzD9WWQYbCZ7xrlz4VJQNdzYBqExFurjq Qe8JQdQ9S4O3HXitaOD5vDWuKfvxtFk2r/+JPrQtUdbMjo9WibM1NTI62bT5v6QMS0 COUandIgGyntIb0mBQaHHWZac67mlWjQrcvuApv4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730918AbgAKKX1 (ORCPT ); Sat, 11 Jan 2020 05:23:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:50380 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730914AbgAKKXY (ORCPT ); Sat, 11 Jan 2020 05:23:24 -0500 Received: from localhost (unknown [62.119.166.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 46AA12082E; Sat, 11 Jan 2020 10:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578738204; bh=1TsBAZt0kGZestdFokrITKiGHIC4EGqDGcbQA7U+5uU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sqay0AGgmG6Yhv4tig2+pFjPwogbgKi+oRweu/4XVfe76aJJckVFbrzXEboLFvR3G tEUWrU05sApUXxFyUahKPKS7qPWunT3uxPI//uDSkzBRHmL244KHJ4znCs6jy78mwd djIPRDvJunq7y5fINtSI7kH2KU8Zj14miLoHx/Ro= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pablo Neira Ayuso , Sasha Levin Subject: [PATCH 5.4 032/165] netfilter: nf_tables_offload: return EOPNOTSUPP if rule specifies no actions Date: Sat, 11 Jan 2020 10:49:11 +0100 Message-Id: <20200111094923.576241586@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200111094921.347491861@linuxfoundation.org> References: <20200111094921.347491861@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Pablo Neira Ayuso [ Upstream commit 81ec61074bcf68acfcb2820cda3ff9d9984419c7 ] If the rule only specifies the matching side, return EOPNOTSUPP. Otherwise, the front-end relies on the drivers to reject this rule. Fixes: c9626a2cbdb2 ("netfilter: nf_tables: add hardware offload support") Signed-off-by: Pablo Neira Ayuso Signed-off-by: Sasha Levin --- net/netfilter/nf_tables_offload.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/nf_tables_offload.c b/net/netfilter/nf_tables_offload.c index 6f7eab502e65..e743f811245f 100644 --- a/net/netfilter/nf_tables_offload.c +++ b/net/netfilter/nf_tables_offload.c @@ -44,6 +44,9 @@ struct nft_flow_rule *nft_flow_rule_create(struct net *net, expr = nft_expr_next(expr); } + if (num_actions == 0) + return ERR_PTR(-EOPNOTSUPP); + flow = nft_flow_rule_alloc(num_actions); if (!flow) return ERR_PTR(-ENOMEM); -- 2.20.1