From: Jonathan Cameron <jic23@kernel.org>
To: Kent Gustavsson <kent@minoris.se>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Fontana <rfontana@redhat.com>,
Shobhit Kukreti <shobhitkukreti@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
Allison Randal <allison@lohutok.net>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: humidity: dht11 remove TODO since it doesn't make sense
Date: Sat, 11 Jan 2020 11:55:29 +0000 [thread overview]
Message-ID: <20200111115529.68d0cf88@archlinux> (raw)
In-Reply-To: <20200104181929.1505510-1-kent@minoris.se>
On Sat, 4 Jan 2020 19:19:29 +0100
Kent Gustavsson <kent@minoris.se> wrote:
> DHT11 isn't addressable and will trigger temperature measurement on any
> data sent on the bus.
>
> Signed-off-by: Kent Gustavsson <kent@minoris.se>
Applied.
Thanks,
Jonathan
> ---
> drivers/iio/humidity/dht11.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/humidity/dht11.c b/drivers/iio/humidity/dht11.c
> index b459600e1a33..d05c6fdb758b 100644
> --- a/drivers/iio/humidity/dht11.c
> +++ b/drivers/iio/humidity/dht11.c
> @@ -174,7 +174,6 @@ static irqreturn_t dht11_handle_irq(int irq, void *data)
> struct iio_dev *iio = data;
> struct dht11 *dht11 = iio_priv(iio);
>
> - /* TODO: Consider making the handler safe for IRQ sharing */
> if (dht11->num_edges < DHT11_EDGES_PER_READ && dht11->num_edges >= 0) {
> dht11->edges[dht11->num_edges].ts = ktime_get_boottime_ns();
> dht11->edges[dht11->num_edges++].value =
prev parent reply other threads:[~2020-01-11 11:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 18:19 [PATCH] iio: humidity: dht11 remove TODO since it doesn't make sense Kent Gustavsson
2020-01-11 11:55 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200111115529.68d0cf88@archlinux \
--to=jic23@kernel.org \
--cc=Jason@zx2c4.com \
--cc=allison@lohutok.net \
--cc=arnd@arndb.de \
--cc=kent@minoris.se \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rfontana@redhat.com \
--cc=shobhitkukreti@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox