Re: [PATCH v4 14/14] dmaengine: tegra-apb: Remove MODULE_ALIAS

Jon Hunter
2020-01-15T10:11:17Z

On 12/01/2020 17:30, Dmitry Osipenko wrote:
> Tegra APB DMA driver is an Open Firmware driver and thus it uses OF alias
> naming scheme which overrides MODULE_ALIAS, meaning that MODULE_ALIAS does
> nothing and could be removed safely.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/dma/tegra20-apb-dma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index fbbb6a60901e..0a45dd77618c 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -1688,7 +1688,6 @@ static struct platform_driver tegra_dmac_driver = {
>
> module_platform_driver(tegra_dmac_driver);
>
> -MODULE_ALIAS("platform:tegra20-apbdma");
> MODULE_DESCRIPTION("NVIDIA Tegra APB DMA Controller driver");
> MODULE_AUTHOR("Laxman Dewangan <ldewangan@nvidia.com>");
> MODULE_LICENSE("GPL v2");

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

--
nvpublic