Re: [PATCH v4 12/14] dmaengine: tegra-apb: Add missing of_dma_controller_free

Jon Hunter
2020-01-15T10:10:10Z

On 12/01/2020 17:30, Dmitry Osipenko wrote:
> The DMA controller shall be released on driver's removal.
>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/dma/tegra20-apb-dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 398a0e1d6506..fbbb6a60901e 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -1586,6 +1586,7 @@ static int tegra_dma_remove(struct platform_device *pdev)
> {
> struct tegra_dma *tdma = platform_get_drvdata(pdev);
>
> + of_dma_controller_free(pdev->dev.of_node);
> dma_async_device_unregister(&tdma->dma_dev);
>
> if (!pm_runtime_enabled(&pdev->dev))
>

Acked-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon

--
nvpublic