From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55CF4C33CA8 for ; Mon, 13 Jan 2020 09:05:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A1E220678 for ; Mon, 13 Jan 2020 09:05:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="iHyodrnj" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726134AbgAMJFT (ORCPT ); Mon, 13 Jan 2020 04:05:19 -0500 Received: from mail.skyhub.de ([5.9.137.197]:53300 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725268AbgAMJFT (ORCPT ); Mon, 13 Jan 2020 04:05:19 -0500 Received: from zn.tnic (p200300EC2F05D300845C97C8540218FC.dip0.t-ipconnect.de [IPv6:2003:ec:2f05:d300:845c:97c8:5402:18fc]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id BB8791EC0CBD; Mon, 13 Jan 2020 10:05:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1578906317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=dKbaCfSlA3zMZXVOUhal7rgsI6faHR3J0+QS6uAvZG8=; b=iHyodrnjURcmi71GzArtn72rgcjvUjXpWX9f6ImlJyI/v0HOpoKpyqLGOy2KcFDL71+AxE p56+jVTXYz8LjKpndchdbjkyzTJVsrD+cGnh2Eh72F5KcQ3LNyWjSCnrfiWA86qrjV6xKI ZUCIY5t4ejxDMe5uPAU/ZY1E0bOdnls= Date: Mon, 13 Jan 2020 10:05:09 +0100 From: Borislav Petkov To: "Luck, Tony" Cc: Chuansheng Liu , linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com Subject: Re: [PATCH v2] x86/mce/therm_throt: Fix the access of uninitialized therm_work Message-ID: <20200113090509.GC13310@zn.tnic> References: <20200107004116.59353-1-chuansheng.liu@intel.com> <20200110182929.GA20511@agluck-desk2.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200110182929.GA20511@agluck-desk2.amr.corp.intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 10, 2020 at 10:29:29AM -0800, Luck, Tony wrote: > On Tue, Jan 07, 2020 at 12:41:16AM +0000, Chuansheng Liu wrote: > > In my ICL platform, it can be reproduced in several times > > of reboot stress. With this fix, the system keeps alive > > for more than 200 times of reboot stress. > > > > V2: Boris shares a good suggestion that we can moving the > > interrupt unmasking at the end of therm_work initialization. > > > > Signed-off-by: Chuansheng Liu > > Looks good to me: > > Acked-by: Tony Luck Thx. This "ICL platform" - whatever that is - is this shipping already so that this qualifies for stable@ or can it go the normal path? -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette