From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A366DC33CAD for ; Mon, 13 Jan 2020 14:34:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E3EF2073D for ; Mon, 13 Jan 2020 14:34:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728799AbgAMOeG (ORCPT ); Mon, 13 Jan 2020 09:34:06 -0500 Received: from mga12.intel.com ([192.55.52.136]:42496 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726074AbgAMOeG (ORCPT ); Mon, 13 Jan 2020 09:34:06 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jan 2020 06:34:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,429,1571727600"; d="scan'208";a="218679884" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga007.fm.intel.com with ESMTP; 13 Jan 2020 06:34:02 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1ir0n5-0000dT-J4; Mon, 13 Jan 2020 16:34:03 +0200 Date: Mon, 13 Jan 2020 16:34:03 +0200 From: Andy Shevchenko To: Mark Brown Cc: John Garry , tudor.ambarus@microchip.com, Linux Kernel Mailing List , chenxiang66@hisilicon.com, Linuxarm , linux-spi , Marek Vasut , "open list:MEMORY TECHNOLOGY..." , Jiancheng Xue , fengsheng5@huawei.com, Mika Westerberg , wanghuiqiang , liusimin4@huawei.com Subject: Re: [PATCH v2 2/3] spi: Add HiSilicon v3xx SPI NOR flash controller driver Message-ID: <20200113143403.GQ32742@smile.fi.intel.com> References: <20200110140726.GB5889@sirena.org.uk> <6db83881-927c-d11c-9c77-23a45892ddab@huawei.com> <20200110193119.GI32742@smile.fi.intel.com> <612a3c5d-69a4-af6b-5c79-c3fb853193ab@huawei.com> <20200113114256.GH3897@sirena.org.uk> <6dd45da9-9ccf-45f7-ed12-8f1406a0a56b@huawei.com> <20200113140627.GJ3897@sirena.org.uk> <20200113142754.GL3897@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200113142754.GL3897@sirena.org.uk> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 13, 2020 at 02:27:54PM +0000, Mark Brown wrote: > On Mon, Jan 13, 2020 at 04:17:32PM +0200, Andy Shevchenko wrote: > > On Mon, Jan 13, 2020 at 4:07 PM Mark Brown wrote: > > > On Mon, Jan 13, 2020 at 01:01:06PM +0000, John Garry wrote: > > > > On 13/01/2020 11:42, Mark Brown wrote: > > > > > > The idiomatic approach appears to be for individual board vendors > > > > > to allocate IDs, you do end up with multiple IDs from multiple > > > > > vendors for the same thing. > > > > > But I am not sure how appropriate that same approach would be for some 3rd > > > > party memory part which we're simply wiring up on our board. Maybe it is. > > > > It seems to be quite common for Intel reference designs to assign > > > Intel IDs to non-Intel parts on the board (which is where I > > > became aware of this practice). > > > Basically vendor of component in question is responsible for ID, but > > it seems they simple don't care. > > AFAICT a lot of the time it seems to be that whoever is writing > the software ends up assigning an ID, that may not be the silicon > vendor. ...which is effectively abusing the ACPI ID allocation procedure. (And yes, Intel itself did it in the past — see badly created ACPI IDs in the drivers) -- With Best Regards, Andy Shevchenko