From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Logan Gunthorpe <logang@deltatee.com>
Subject: Re: [PATCH v1 4/4] PCI: Allow extend_bridge_window() to shrink resource if necessary
Date: Mon, 13 Jan 2020 18:21:50 +0200 [thread overview]
Message-ID: <20200113162150.GO2838@lahna.fi.intel.com> (raw)
In-Reply-To: <PSXP216MB043869924730BFD3AA97B0A0803E0@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
On Wed, Jan 08, 2020 at 01:36:04AM +0000, Nicholas Johnson wrote:
> > Where's the patch that changes the caller so "new_size" may be smaller
> > than "size"? I guess it must be "[3/3] PCI: Consider alignment of
> > hot-added bridges ..." because that's the only one that makes a
> > non-trivial change, right?
>
> As above, there was always a possibility of the new_size being smaller.
> For some reason, 1M is assigned to bridges, even if nothing is below
> them (for example, unused non hotplug bridges in a Thunderbolt dock). It
> may be an edge case if we are low on space, but theoretically it can
> happen.
>
> Also, when writing this, Mika was not interested in using hpmemsize,
> which, when used, will cause new_size to be smaller than the current
> size (actual size and add_size combined).
Just a small correction here about my motivation. So I'm testing on a
hardware where the BIOS assigns initial resources to the root/downstream
ports which is the majority of Thunderbolt capable PC systems nowadays.
Therefore the user does not need to pass any additional command line
parameters to get the ports working properly.
However, I'm of course interested in getting Linux PCI resource
management as good as possible regardless whether the firmware/BIOS
assigns them or not ;-)
next prev parent reply other threads:[~2020-01-13 16:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-06 15:48 [PATCH v1 4/4] PCI: Allow extend_bridge_window() to shrink resource if necessary Nicholas Johnson
2020-01-07 20:34 ` Bjorn Helgaas
2020-01-08 1:36 ` Nicholas Johnson
2020-01-13 16:21 ` Mika Westerberg [this message]
2020-01-15 14:51 ` Nicholas Johnson
2020-01-15 14:59 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200113162150.GO2838@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=benh@kernel.crashing.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox