From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9DDF9C33CAF for ; Mon, 13 Jan 2020 17:46:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7C34821556 for ; Mon, 13 Jan 2020 17:46:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728766AbgAMRqH (ORCPT ); Mon, 13 Jan 2020 12:46:07 -0500 Received: from muru.com ([72.249.23.125]:50738 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726435AbgAMRqH (ORCPT ); Mon, 13 Jan 2020 12:46:07 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 245D98047; Mon, 13 Jan 2020 17:46:48 +0000 (UTC) Date: Mon, 13 Jan 2020 09:46:03 -0800 From: Tony Lindgren To: Colin Ian King Cc: Vinod Koul , Dan Williams , Peter Ujfalusi , dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next][V2] dmaengine: ti: omap-dma: don't allow a null od->plat pointer to be dereferenced Message-ID: <20200113174603.GK5885@atomide.com> References: <20200109131953.157154-1-colin.king@canonical.com> <20200110074605.GD2818@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Colin Ian King [200110 09:22]: > On 10/01/2020 07:46, Vinod Koul wrote: > > On 09-01-20, 13:19, Colin King wrote: > >> From: Colin Ian King > >> > >> Currently when the call to dev_get_platdata returns null the driver issues > >> a warning and then later dereferences the null pointer. Avoid this issue > >> by returning -ENODEV errror rather when the platform data is null and > > > > s/errror/error :) never thought would correct Colin on spelling :) > > Doh, I need to add that to the checkpatch dictionary ;-) > > If this can be fixed up before it's applied then this would be > appreciated rather than me sending a V3. I've fixed i up and pushed out into omap-for-v5.6/sdma. Thanks, Tony