Re: [PATCH v7 05/21] clk: tegra: Fix Tegra PMC clock out parents

Sowjanya Komatineni
2020-01-09T17:18:21Z

On 1/8/20 12:34 AM, Nicolas Chauvet wrote:
> Le mer. 8 janv. 2020 à 05:27, Sowjanya Komatineni
> <skomatineni@nvidia.com> a écrit :
>> Tegra PMC clock out parents are osc, osc_div2, osc_div4 and extern
>> clock.
>>
>> Clock driver is using incorrect parents clk_m, clk_m_div2, clk_m_div4
>> for PMC clocks.
>>
>> This patch fixes this.
>>
>> Tested-by: Dmitry Osipenko <digetx@gmail.com>
>> Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
>> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
>> ---
>> drivers/clk/tegra/clk-tegra-pmc.c | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/clk/tegra/clk-tegra-pmc.c b/drivers/clk/tegra/clk-tegra-pmc.c
>> index bec3e008335f..5e044ba1ae36 100644
>> --- a/drivers/clk/tegra/clk-tegra-pmc.c
>> +++ b/drivers/clk/tegra/clk-tegra-pmc.c
>> @@ -49,16 +49,16 @@ struct pmc_clk_init_data {
>>
>> static DEFINE_SPINLOCK(clk_out_lock);
>>
>> -static const char *clk_out1_parents[] = { "clk_m", "clk_m_div2",
>> - "clk_m_div4", "extern1",
>> +static const char *clk_out1_parents[] = { "osc", "osc_div2",
>> + "osc_div4", "extern1",
>> };
>>
>> -static const char *clk_out2_parents[] = { "clk_m", "clk_m_div2",
>> - "clk_m_div4", "extern2",
>> +static const char *clk_out2_parents[] = { "osc", "osc_div2",
>> + "osc_div4", "extern2",
>> };
>>
>> -static const char *clk_out3_parents[] = { "clk_m", "clk_m_div2",
>> - "clk_m_div4", "extern3",
>> +static const char *clk_out3_parents[] = { "osc", "osc_div2",
>> + "osc_div4", "extern3",
>> };
>>
>> static struct pmc_clk_init_data pmc_clks[] = {
>> --
>> 2.7.4
> Out of curiosity, this patch touch the clk-tegra-pmc.c file which is
> later removed (by patch 11).
> Is this change made for bugfix ? Is there a stable tag missing ?
Will resend final version with stable tags for patches that should be
backported.