Re: [PATCH 5.4 17/78] HID: Fix slab-out-of-bounds read in hid_field_extract (Broken!)

Jiri Kosina
2020-02-05T09:54:49Z

On Wed, 5 Feb 2020, Enderborg, Peter wrote:

> >> This patch breaks Elgato StreamDeck.
>
> > Does that mean the device is broken with a too-large of a report?
>
> Yes.

In which way does the breakage pop up? Are you getting "report too long"
errors in dmesg, or the device just doesn't enumerate at all?

Could you please post /sys/kernel/debug/hid/<device>/rdesc contents, and
if the device is at least semi-alive, also contents of
/sys/kernel/debug/hid/<device>/events from the time it misbehaves?

> > Is it broken in Linus's tree? If so, can you work with the HID
> > developers to fix it there so we can backport the fix to all stable
> > trees?
>
> I cant see that there are any other fixes upon this so I dont think so.
> I can try.
>
>
> Jiri is in the loop. I guess he is the "HID developers" ?

Thanks,

--
Jiri Kosina
SUSE Labs