From: Borislav Petkov <bp@alien8.de>
To: Colin King <colin.king@canonical.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H . Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/microcode/amd: fix uninitalized structure cp
Date: Tue, 14 Jan 2020 12:38:34 +0100 [thread overview]
Message-ID: <20200114113834.GE31032@zn.tnic> (raw)
In-Reply-To: <20200114111505.320186-1-colin.king@canonical.com>
On Tue, Jan 14, 2020 at 11:15:05AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> In the case where cp is not assigned to the return from
> the call to find_microcode_in_initrd
Where does this happen? I don't see it.
> cp is uninitialized when
> it is assigned to *ret. Functions that call __load_ucode_amd
> such as load_ucode_amd_bsp can therefore end up checking bogus
> values cp.data and cp.size. Fix this by ensuring cp is
> initialized as all zero and remove the redundant initialization
> of cp in load_ucode_amd_bsp.
>
> Addresses-Coverity: ("Uninitialized scalar variable")
I already asked about those: either document what those tags mean or
remove them.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2020-01-14 11:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 11:15 [PATCH] x86/microcode/amd: fix uninitalized structure cp Colin King
2020-01-14 11:38 ` Borislav Petkov [this message]
2020-01-14 11:51 ` Colin Ian King
2020-01-14 11:58 ` Thomas Gleixner
2020-01-14 12:01 ` Borislav Petkov
2020-01-14 12:03 ` Colin Ian King
2020-01-14 12:10 ` Borislav Petkov
2020-01-14 14:08 ` Colin Ian King
2020-01-14 15:01 ` Borislav Petkov
2020-01-15 4:25 ` Dan Carpenter
2020-01-15 12:42 ` Borislav Petkov
2020-01-16 9:44 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114113834.GE31032@zn.tnic \
--to=bp@alien8.de \
--cc=colin.king@canonical.com \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox