From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martin Fuzzey <martin.fuzzey@flowbird.group>
Cc: "Arve Hjønnevåg" <arve@android.com>,
"Todd Kjos" <tkjos@android.com>,
"Martijn Coenen" <maco@android.com>,
"Joel Fernandes" <joel@joelfernandes.org>,
"Christian Brauner" <christian@brauner.io>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binder: fix log spam for existing debugfs file creation.
Date: Tue, 14 Jan 2020 16:22:49 +0100 [thread overview]
Message-ID: <20200114152249.GA2041689@kroah.com> (raw)
In-Reply-To: <1578671054-5982-1-git-send-email-martin.fuzzey@flowbird.group>
On Fri, Jan 10, 2020 at 04:44:01PM +0100, Martin Fuzzey wrote:
> Since commit 43e23b6c0b01 ("debugfs: log errors when something goes wrong")
> debugfs logs attempts to create existing files.
>
> However binder attempts to create multiple debugfs files with
> the same name when a single PID has multiple contexts, this leads
> to log spamming during an Android boot (17 such messages during
> boot on my system).
>
> Fix this by checking if we already know the PID and only create
> the debugfs entry for the first context per PID.
>
> Do the same thing for binderfs for symmetry.
>
> Signed-off-by: Martin Fuzzey <martin.fuzzey@flowbird.group>
Does this need a "Fixes:" and cc: stable tag?
And it would be good to get a review from the binder maintainer(s) to
see if this is sane or not...
thanks,
greg k-h
next prev parent reply other threads:[~2020-01-14 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-10 15:44 [PATCH] binder: fix log spam for existing debugfs file creation Martin Fuzzey
2020-01-14 15:22 ` Greg Kroah-Hartman [this message]
2020-01-17 22:30 ` Todd Kjos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114152249.GA2041689@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@android.com \
--cc=martin.fuzzey@flowbird.group \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox