From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Slaby <jslaby@suse.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] tty: baudrate: Synchronise baud_table[] and baud_bits[]
Date: Tue, 14 Jan 2020 18:27:56 +0100 [thread overview]
Message-ID: <20200114172756.GA2052011@kroah.com> (raw)
In-Reply-To: <20200114170917.36947-1-andriy.shevchenko@linux.intel.com>
On Tue, Jan 14, 2020 at 07:09:17PM +0200, Andy Shevchenko wrote:
> Synchronize baud rate tables for better readability.
"Synchronize"? With what? Why? I'm all for cleaning up code, but this
just seems totally gratuitous.
We have whole serial drivers with _THOUSANDS_ of checkpatch issues, and
this is bothering you? :)
greg k-h
next prev parent reply other threads:[~2020-01-14 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 17:09 [PATCH v1] tty: baudrate: Synchronise baud_table[] and baud_bits[] Andy Shevchenko
2020-01-14 17:27 ` Greg Kroah-Hartman [this message]
2020-01-15 16:33 ` Andy Shevchenko
2020-01-15 17:21 ` Greg Kroah-Hartman
2020-01-15 22:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200114172756.GA2052011@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox