From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43AA9C33C9E for ; Tue, 14 Jan 2020 17:29:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 190E624676 for ; Tue, 14 Jan 2020 17:29:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579022945; bh=i70L8DNui8VPmavm+tZ8ivBeZkZeG8PnKWDI53xqtSM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=feOMsWN8X4al8UYf3aPGGKhOTK1YnacOcJ0bn/KjVDCPs+O58UqCkM8O5ckBO4s57 oAHmObjFJGY7RKVWdR4DbZkUupOFtqxsdTbQCjepA7UHCl4GSH5Hxkosf8LZ8q3EBu fsppf+RQJBoPQ8Uo6pdQJDN3eqsjZH6Vs3bh9TmM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728761AbgANR3E (ORCPT ); Tue, 14 Jan 2020 12:29:04 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58536 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbgANR3E (ORCPT ); Tue, 14 Jan 2020 12:29:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=i70L8DNui8VPmavm+tZ8ivBeZkZeG8PnKWDI53xqtSM=; b=t1Oe+sLzVhteGVH2G8L+ZuR9d 9utrcXUyXrsEEQ/BJ6ZWl8JUkosr9QdU1c25uUJ79QZPFWw4dH0VxlptSVkRIH+eNsz7uWLaowKzz bgZPklFW6glxzoPk2PfOWBAv2D8dgvyuOKSrZSrBaS7HS/Y4X20Ab+mqLujGICknxGT2E=; Received: from fw-tnat-cam7.arm.com ([217.140.106.55] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1irPzh-0001qO-Tk; Tue, 14 Jan 2020 17:28:45 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 97845D01965; Tue, 14 Jan 2020 17:28:45 +0000 (GMT) Date: Tue, 14 Jan 2020 17:28:45 +0000 From: Mark Brown To: Catalin Marinas Cc: Will Deacon , Paul Elliott , Peter Zijlstra , Yu-cheng Yu , Amit Kachhap , Vincenzo Frascino , Marc Zyngier , Eugene Syromiatnikov , Szabolcs Nagy , "H.J. Lu" , Andrew Jones , Kees Cook , Arnd Bergmann , Jann Horn , Richard Henderson , Kristina =?utf-8?Q?Mart=C5=A1enko?= , Thomas Gleixner , Florian Weimer , Sudakshina Das , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Dave Martin Subject: Re: [PATCH v4 02/12] ELF: Add ELF program property parsing support Message-ID: <20200114172845.GF3897@sirena.org.uk> References: <20191211154206.46260-1-broonie@kernel.org> <20191211154206.46260-3-broonie@kernel.org> <20200114163402.GH30444@arrakis.emea.arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="656hIAUFSU7Oh46B" Content-Disposition: inline In-Reply-To: <20200114163402.GH30444@arrakis.emea.arm.com> X-Cookie: Programming is an unnatural act. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --656hIAUFSU7Oh46B Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 14, 2020 at 04:34:03PM +0000, Catalin Marinas wrote: > The logic looks fine to me but I'm not sure the choice of returning -EIO > is suitable in most cases. I think apart from kernel_read() returning an > error, there rest look like malformed ELF notes, so rather -ENOEXEC. Sure, I don't have strong opinions either way. --656hIAUFSU7Oh46B Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4d+koACgkQJNaLcl1U h9BzOAf/ZW4b8JHQ9qlWZwLXs7dElEQgCxM18zekE7pOdxU3oF7g7qLspavQhRB9 6VwtDC7KE1ohuOMkwPE5HFSzlOW5WyGKodH8581UTigsQ3vp5Y4OKdIwNYCmvI0O OaPHa1Us+qy5w2fwhYFGQpJaKBAo52VFWFb1eS65cv/A1RVktrwfF0/5CUKQlOvT eUsZAkU1zgYf5BTaFmLlhrKlfbfOZE7U3nSMfRpM9k0uHS8TkV4gJY8Krs2/IKWG 1ePbKRpoEnul7u915WZxspdgU8UI556Y1gmiJEO1RyMOWH56mWwEgHrQc/8MxLpG AoSckdNGC+G7zG4pARh7eWJDwYq3GA== =w1Xx -----END PGP SIGNATURE----- --656hIAUFSU7Oh46B--