From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DFEDC33CB2 for ; Tue, 14 Jan 2020 19:13:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E954724672 for ; Tue, 14 Jan 2020 19:13:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="IoV0u8G3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728787AbgANTN4 (ORCPT ); Tue, 14 Jan 2020 14:13:56 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:37430 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726523AbgANTNz (ORCPT ); Tue, 14 Jan 2020 14:13:55 -0500 Received: by mail-pj1-f67.google.com with SMTP id m13so6306594pjb.2 for ; Tue, 14 Jan 2020 11:13:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Kh1Ge+Ojyq1Hkaf57+ksFQlpw/tvYEo5VWAEqDe26e0=; b=IoV0u8G3OE4qe/OlOUrmQtTvkn0Ck8iGTgGitUdy4pm3zeqyty3RtPcor2vp/ZM5UM bh3Y3Dm0Rl8FtYVdIGq1TmyzYHROP92D3Yb8/avJnDjSPv2yCHiRXrJt9rFiOnhFOgfx J1uuzsbaA6SZJOUNcD3OseGl4+stFJaViEmj8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Kh1Ge+Ojyq1Hkaf57+ksFQlpw/tvYEo5VWAEqDe26e0=; b=c+XGeaya0IbH4vJPIgHBHNl9D6TCNvOVlwjptqXeVIawaySdxUq0o9HhkeoaysvdCK yEL34Vxb5Yo7ZHcP/WXdO8tmExtOLh+UBxSSNVmRyFjzr670+7AHA8xZlWdRhmLDypbT d1lT8avAYMFXzUV9aKrZte22ANKJNB8/1ge4e249FAEOxLQpCGQtTqI5VluJLPq03JD1 8G3PPbUAUMYMPI0h3W4MPlS5IwYbJVONreLnqpe777uexH4l6yeFZP4687AvFroQKts0 fj7RND2LpW8rGnyYd6Js+z0Ch7nQwXEQse4XwqC7XOyCZhL534iTjLMQIIsWsC5d57rD cFeA== X-Gm-Message-State: APjAAAURALyDrYjyoN+4wJuMoJ4A9ZYUEshbb700e0N85Pys0J8btcX6 wTNn1AIs2X6k+xoZF/USFUNt8w== X-Google-Smtp-Source: APXvYqwzRsJ2RVe43UkCslTgq8Oqb8xg0wTDZUJHvubtVap0H3WXcQ3V3xpS5d6YsDXJ15yBA5c0TQ== X-Received: by 2002:a17:902:8c84:: with SMTP id t4mr21515599plo.101.1579029235167; Tue, 14 Jan 2020 11:13:55 -0800 (PST) Received: from localhost ([2620:15c:202:1:4fff:7a6b:a335:8fde]) by smtp.gmail.com with ESMTPSA id v4sm18628483pff.174.2020.01.14.11.13.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2020 11:13:54 -0800 (PST) Date: Tue, 14 Jan 2020 11:13:53 -0800 From: Matthias Kaehlcke To: Chanwoo Choi Cc: Leonard Crestez , Chanwoo Choi , Viresh Kumar , MyungJoo Ham , Kyungmin Park , Zhang Rui , Daniel Lezcano , Amit Kucheria , "linux-kernel@vger.kernel.org" , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" Subject: Re: [PATCH 2/2] PM / devfreq: Use exclusively PM QoS to determine frequency limits Message-ID: <20200114191353.GL89495@google.com> References: <20200110094913.1.I146403d05b9ec82f48b807efd416a57f545b447a@changeid> <20200110094913.2.Ie8eacf976ce7a13e421592f5c1ab8dbdc537da5c@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 02:35:48AM +0900, Chanwoo Choi wrote: > On Wed, Jan 15, 2020 at 1:08 AM Leonard Crestez wrote: > > > > On 13.01.2020 09:24, Chanwoo Choi wrote: > > > Hi, > > > > > > Any device driver except for devfreq_cooling.c might > > > use dev_pm_opp_enable/disable interface. > > > So, don't need to remove the devfreq->scaling_max_freq > > > and devfreq->scaling_min_freq for supporting OPP interface. > > > > It seems that devfreq_cooling was the only upstream user of > > dev_pm_opp_enable and the remaining callers of dev_pm_opp_disable are > > probe-time checks. > > OPP interface has still dev_pm_opp_enable and dev_pm_opp_disable > function. As long as remains them, any device driver related to devfreq > could call them at some time. The devfreq supports the OPP interface, > not just for only devfreq_cooling. I would like to remove the disabled OPP handling since no devfreq device makes use of dev_pm_opp_enable/disable, but I fear you are right that we have to keep it as long as the API is available.