Re: [PATCH v3 35/36] platform/x86: intel_pmc_ipc: Convert to MFD

Lee Jones
2020-01-20T11:14:38Z

On Mon, 20 Jan 2020, Mika Westerberg wrote:

> On Mon, Jan 20, 2020 at 08:12:46AM +0000, Lee Jones wrote:
> > > Well, by "library" I mean that the SCU IPC itself does not bind to
> > > anything but instead it gets called by different drivers such as this
> > > one passing the device pointer that is the SCU IPC device. Here for
> > > example it is the platfrom device created from an ACPI description.
> >
> > Not keen on that at all. Why can it not be a platform device?
>
> We also call the same library from a PCI driver (intel_scu_pcidrv.c in
> this series) where the device is of type struct pci_dev.

Not sure I understand the issue.

What does the device do?

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog