Re: [PATCH v5] reboot: support offline CPUs before reboot

Hsin-Yi Wang
2020-01-16T09:19:11Z

On Thu, Jan 16, 2020 at 8:30 AM Thomas Gleixner <tglx@linutronix.de> wrote:
>
> Hsin-Yi Wang <hsinyi@chromium.org> writes:
>
> > Currently system reboots uses architecture specific codes (smp_send_stop)
> > to offline non reboot CPUs. Most architecture's implementation is looping
> > through all non reboot online CPUs and call ipi function to each of them. Some
> > architecture like arm64, arm, and x86... would set offline masks to cpu without
> > really offline them. This causes some race condition and kernel warning comes
> > out sometimes when system reboots.
>
> 'some race condition and kernel warning' is pretty useless information.
> Please describe exactly which kind of issues are caused by the current
> mechanism. Especially the race conditions are the interesting part (the
> warnings are just a consequence).
>
> > This patch adds a config ARCH_OFFLINE_CPUS_ON_REBOOT, which would
> > offline cpus in
>
> Please read Documentation/process/submitting-patches.rst and search for
> 'This patch'.
>
> > migrate_to_reboot_cpu(). If non reboot cpus are all offlined here, the loop for
> > checking online cpus would be an empty loop.
>
> This does not make any sense. The issues which you are trying to solve
> are going to be still there when CONFIG_HOTPLUG_CPU is disabled.
>
> > If architecture don't enable this config, or some cpus somehow fails
> > to offline, it would fallback to ipi function.
>
> This is really a half baken solution which keeps the various pointlessly
> different pseudo reboot/kexec offlining implementations around. So with
> this we have yet more code which only works depending on kernel
> configuration and has the issue of potentially not being able to offline
> a CPU. IOW this is going to fail completely in cases where a system is
> in a state which prevents regular hotplug.
>
> The existing pseudo-offline functions have timeouts and eventually a
> fallback, e.g. the NMI fallback on x86. With this proposed regular
> offline solution this will just get stuck w/o a chance to force
> recovery.
>
> While I like the idea and surely agree that the ideal solution is to
> properly shutdown the CPUs on reboot, we need to take a step back and
> look at the minimum requirements for a regular shutdown/reboot and at
> the same time have a look at the requirements for emergency shutdown and
> kexec/kcrash. Having proper information about the race conditions and
> warnings you mentioned would be a good starting point.
>

We saw this issue on regular reboot (not panic) on arm64: If tick
broadcast and smp_send_stop() happen together and the first broadcast
arrives to some idled CPU that hasn't already executed reboot ipi to
run in spinloop, it would try to broadcast to another CPU, but that
target CPU is already marked as offline by set_cpu_online() in reboot
ipi, and a warning comes out since tick_handle_oneshot_broadcast()
would check if it tries to broadcast to offline cpus. Most of the time
the CPU getting the broadcast interrupt is already in the spinloop and
thus isn't going to receive interrupts from the broadcast timer.

[ 27.032080] Set kernel.core_pattern before fs.suid_dumpable.
[ 27.978628] reboot: Restarting system
[ 27.978919] WARNING: CPU: 3 PID: 0 at
/mnt/host/source/src/third_party/kernel/v4.19/kernel/time/tick-broadcast.c:652
tick_handle_oneshot_broadcast+0x1f8/0x214
[ 27.978932] Modules linked in: rfcomm uinput bridge stp llc
nf_nat_tftp nf_conntrack_tftp nf_nat_ftp nf_conntrack_ftp esp6 ah6
xfrm6_mode_tunnel xfrm6_mode_transport xfrm4_mode_tunnel
xfrm4_mode_transport ip6t_REJECT ip6t_ipv6header hci_uart btqca
bluetooth ipt_MASQUERADE ecdh_generic lzo_rle lzo_compress zram fuse
cros_ec_sensors_sync cros_ec_sensors_ring cros_ec_light_prox
cros_ec_sensors industrialio_triggered_buffer kfifo_buf
cros_ec_sensors_core ath10k_sdio ath10k_core ath mac80211 cfg80211
asix usbnet mii joydev
[ 27.979102] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G S
4.19.56 #79
[ 27.979113] Hardware name: MediaTek krane sku176 board (DT)
[ 27.979127] pstate: 00000085 (nzcv daIf -PAN -UAO)
[ 27.979140] pc : tick_handle_oneshot_broadcast+0x1f8/0x214
[ 27.979154] lr : tick_handle_oneshot_broadcast+0x108/0x214
[ 27.979162] sp : fffffff85c851610
[ 27.979171] x29: fffffff85c851670 x28: ffffff9082785510
[ 27.979187] x27: ffffff90822da700 x26: ffffff90826169c8
[ 27.979202] x25: ffffff9082616000 x24: 0000000000000001
[ 27.979217] x23: ffffff90827854f8 x22: 000000067a6599b8
[ 27.979232] x21: 0000000000000000 x20: 7fffffffffffffff
[ 27.979248] x19: ffffff9082785508 x18: 0000000000000000
[ 27.979263] x17: 0000000000000000 x16: 0000000000000000
[ 27.979278] x15: 0000000000000000 x14: fffffff85bf08040
[ 27.979293] x13: ffffff9082785000 x12: 0000000000000069
[ 27.979308] x11: ffffff9082785000 x10: 0000000000000018
[ 27.979323] x9 : 0000000000000010 x8 : ffffff9082615000
[ 27.979338] x7 : 0000000000000000 x6 : 000000000000003f
[ 27.979353] x5 : 0000000000000040 x4 : 0000000000000102
[ 27.979367] x3 : 0000000000000000 x2 : 0000000000000007
[ 27.979383] x1 : 0000000000000008 x0 : 0000000000000008
[ 27.979399] Call trace:
[ 27.979413] tick_handle_oneshot_broadcast+0x1f8/0x214
[ 27.979429] mtk_syst_handler+0x34/0x44
[ 27.979443] __handle_irq_event_percpu+0x134/0x254
[ 27.979454] handle_irq_event_percpu+0x34/0x8c
[ 27.979465] handle_irq_event+0x48/0x78
[ 27.979478] handle_fasteoi_irq+0xd0/0x1a4
[ 27.979492] __handle_domain_irq+0x84/0xc4
[ 27.979505] gic_handle_irq+0x154/0x1a4
[ 27.979516] el1_irq+0xb0/0x128
[ 27.979531] cpuidle_enter_state+0x298/0x328
[ 27.979543] cpuidle_enter+0x30/0x40
[ 27.979557] do_idle+0x154/0x270
[ 27.979569] cpu_startup_entry+0x24/0x28
[ 27.979584] secondary_start_kernel+0x15c/0x168
[ 27.979594] ---[ end trace 57ed1d1fade60372 ]---

If system supports hotplug, _cpu_down() would properly handle tasks
termination such as remove CPU from timer broadcasting by
tick_offline_cpu()...etc, as well as some interrupt handling.

https://lore.kernel.org/patchwork/patch/1117201/ is a previous attempt
to solve this issue by introducing another mask in reboot ipi function
to avoid the cpu_online_mask being looked up in too many different
places.

> > Opt in this config for architectures that support CONFIG_HOTPLUG_CPU.
>
> This is not opt-in. You force that on all architectures which support
> CONFIG_HOTPLUG_CPU. The way we do this normally is to provide the
> infrastructure first and then have separate patches (one per
> architecture) enabling this, which allows the architecture maintainers
> to decide individually.

Acked, thanks.

>
> Thanks,
>
> tglx