Re: [PATCH 5/5] arm64: dts: allwinner: a64: add support for PineTab

Sam Ravnborg
2020-01-10T18:12:27Z

Hi Icenowy.

checkpatch noticed a small inconsistency in the i2c1 node.

>
> Misc:
> - Debug UART is muxed with the headphone jack, with the switch next to
> the microSD slot.
> - A bosch BMA223 accelerometer is connected to the I2C bus of A64 SoC.
> - Wi-Fi and Bluetooth are available via a RTL8723CS chip, similar to the
> one in Pinebook.
>
> +
> +&i2c1 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2c1_pins>;
> + status = "okay";
> +
> + bma223@18 {
> + compatible = "bosch,bma223", "bosch,bma222e";
These compatible have no binding file?!?

> + reg = <0x18>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 5 IRQ_TYPE_LEVEL_HIGH>; /* PH5 */
> + mount-matrix = "0", "-1", "0",
> + "-1", "0", "0",
> + "0", "0", "-1";
> + };
> +};

bosch,bma222e is referenced by a driver, whereas this is the
first reference of bosch,bma223.

Sam