From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B6A5C33CB1 for ; Wed, 15 Jan 2020 16:06:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29C872187F for ; Wed, 15 Jan 2020 16:06:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729028AbgAOQGK (ORCPT ); Wed, 15 Jan 2020 11:06:10 -0500 Received: from mx2.suse.de ([195.135.220.15]:50034 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726550AbgAOQGK (ORCPT ); Wed, 15 Jan 2020 11:06:10 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 45501AD07; Wed, 15 Jan 2020 16:06:08 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id 1394FDA791; Wed, 15 Jan 2020 17:05:55 +0100 (CET) Date: Wed, 15 Jan 2020 17:05:54 +0100 From: David Sterba To: YueHaibing Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, nborisov@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] btrfs: Fix return value while kcalloc fails in btrfs_rmap_block Message-ID: <20200115160554.GR3929@suse.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, YueHaibing , clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, nborisov@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200115142027.56960-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200115142027.56960-1-yuehaibing@huawei.com> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 10:20:27PM +0800, YueHaibing wrote: > In btrfs_rmap_block(), if kcalloc fails, it should return > -ENOMEM instead of 0. > > Fixes: 767f58cdaf20 ("btrfs: Refactor btrfs_rmap_block to improve readability") > Signed-off-by: YueHaibing Thanks, folded to the patch.