From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9F4C32771 for ; Wed, 15 Jan 2020 17:21:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1239B24656 for ; Wed, 15 Jan 2020 17:21:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579108872; bh=dUOS7Sbd/0yMtiwpyUyOXAg054W2R7jVPYgksxRkGAc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=xr5LCT+jH47xNJjLR8J7nxL/aGzieHFSW9kXr529K9EduKR72kkXsqOrcWQCqPokP QLSnkyToDd6rECQMf3V5c//k7ZDU2m87Lt0FBsDqg/a8hnjjTpCU5i7lNtP+H6EAfD sli+domoAEahtINXQaBle/tYjm0BFDUHcXI8zQPM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729019AbgAORVL (ORCPT ); Wed, 15 Jan 2020 12:21:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:49032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727016AbgAORVK (ORCPT ); Wed, 15 Jan 2020 12:21:10 -0500 Received: from localhost (unknown [217.68.49.72]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8840C207FF; Wed, 15 Jan 2020 17:21:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579108870; bh=dUOS7Sbd/0yMtiwpyUyOXAg054W2R7jVPYgksxRkGAc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EC8bKknXcmw+4ysBdgdqSuUlqY6Man3IhZCLgHBbZUT/MfA28EPsoq1XUDymjZNDB 0MzUg3fNBDTHYrbJAlV4XfzQVgShuujpjJ8ETKhkso4zKT4X3XHgA6jmF9B91xGzdZ PknufLsPoKRSmRd6VblqBsy8cFg3c6pDCHfK6iFE= Date: Wed, 15 Jan 2020 18:21:06 +0100 From: Greg Kroah-Hartman To: Andy Shevchenko Cc: Jiri Slaby , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] tty: baudrate: Synchronise baud_table[] and baud_bits[] Message-ID: <20200115172106.GA4127163@kroah.com> References: <20200114170917.36947-1-andriy.shevchenko@linux.intel.com> <20200114172756.GA2052011@kroah.com> <20200115163327.GF32742@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200115163327.GF32742@smile.fi.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 15, 2020 at 06:33:27PM +0200, Andy Shevchenko wrote: > On Tue, Jan 14, 2020 at 06:27:56PM +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 14, 2020 at 07:09:17PM +0200, Andy Shevchenko wrote: > > > Synchronize baud rate tables for better readability. > > > > "Synchronize"? With what? > > Between each other. This SPARC thingy makes it's harder to follow. Ok, be more specific please, a better changelog is key here. > > Why? I'm all for cleaning up code, but this > > just seems totally gratuitous. > > Btw, while doing it I found that SPARC actually supports more baud rates than > defined in those arrays. Without this patch I would not (easily) notice that. > Should I also attach another patch and resend? Yes, that might justify this patch's acceptance :) thanks, greg k-h