From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB5B4C32771 for ; Wed, 15 Jan 2020 17:45:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9484F206D7 for ; Wed, 15 Jan 2020 17:45:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729011AbgAORp4 (ORCPT ); Wed, 15 Jan 2020 12:45:56 -0500 Received: from sauhun.de ([88.99.104.3]:39068 "EHLO pokefinder.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728896AbgAORpz (ORCPT ); Wed, 15 Jan 2020 12:45:55 -0500 Received: from localhost (p54B33239.dip0.t-ipconnect.de [84.179.50.57]) by pokefinder.org (Postfix) with ESMTPSA id C51E02C0742; Wed, 15 Jan 2020 18:45:53 +0100 (CET) Date: Wed, 15 Jan 2020 18:45:53 +0100 From: Wolfram Sang To: Krzysztof Kozlowski Cc: Vladimir Zapolskiy , Sylvain Lemieux , Linus Walleij , Arnd Bergmann , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jean Delvare , Jarkko Nikula Subject: Re: [PATCH v2 1/4] i2c: pmcmsp: Use proper printk format for resource_size_t Message-ID: <20200115174553.GI1239@ninjato> References: <1578992765-1418-1-git-send-email-krzk@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="16qp2B0xu0fRvRD7" Content-Disposition: inline In-Reply-To: <1578992765-1418-1-git-send-email-krzk@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --16qp2B0xu0fRvRD7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + "Unable to get memory/io address region %pap\n", > + &(res->start)); My first thought was "parens not needed"; not because I like being picky but because it doesn't look more readable to me. checkpatch agrees: CHECK: Unnecessary parentheses around res->start #30: FILE: drivers/i2c/busses/i2c-pmcmsp.c:278: + &(res->start)); --16qp2B0xu0fRvRD7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAl4fT9EACgkQFA3kzBSg Kbb91BAAjPtROcvdlQNblLFk8PxjameI1NyWeapD6DkN0jImw+pfJ5nJFMnOu+Wh F6XntHHABtG0TIZrWZcaapSG2HtJBxJq1+1H00YyQMtlUqKnBsqZCcJ0qavL1Of8 4QoH/tLRxc263i7eSKo8Q/v7NJdrfzf6SXDGj0d2uyOgHXkiBcbiw7YOeIruvgF2 nPCAe65wsLvlS2/oVyEGjSuguyiFvkhz5y75LikWQ6KPA7mOTYYlsDFldEI0Jr0n Cjcp26950LR3uH6dkPnKJncyvgo+bqTCXty2VQZriONaIM2BgsziesYD6lZchTvT 0OyNUxrFbM6ajIuwtLD5HMiQ7GmvfHRABUscFjhWutXrjyBTmLKiWlDHMsVLnYwb z07XxGhjmufTlBSPI4rXIZtyMv81+aQGagjZXWDwefUnsKQjilb7DFo1f5fbnsxC sKO/C6Pi4scgwXvUCBgok0xczp1jVE2NhVLgATIvSiGqzTaTSt0xzlIZd06bStO+ uUBiyilC5TPyGU9npLRLvcaDg2LROH9UrTrb+vZX4qz5EOs25uMKb55F9oLtC5cc STUdu4uesKZgQc6xQEZ5ZoiuWiXTr/HZ6W8sBeaIO74SLgo+g4/6mtyaRBkz53u3 vibl9z27lUGZskp0ClfuU5AD1mH0GnRTizBlJmnZIBTmmzKM5bQ= =cFSU -----END PGP SIGNATURE----- --16qp2B0xu0fRvRD7--