From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88ED2C33CB6 for ; Thu, 16 Jan 2020 04:59:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E1CA20730 for ; Thu, 16 Jan 2020 04:59:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nTEBofKC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731109AbgAPE7Y (ORCPT ); Wed, 15 Jan 2020 23:59:24 -0500 Received: from mail-pf1-f201.google.com ([209.85.210.201]:52600 "EHLO mail-pf1-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729370AbgAPE7Y (ORCPT ); Wed, 15 Jan 2020 23:59:24 -0500 Received: by mail-pf1-f201.google.com with SMTP id 145so12341321pfx.19 for ; Wed, 15 Jan 2020 20:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=Yujd7NYO/Gpv5hGCan+Hwvd6fcY54ztoBNLrmT1puBg=; b=nTEBofKCmnS3/2Efie7j4FZM7iYpE9k7Y1Z9TsJLPzuhnrp5h87vi8ctGlA2+HfJAl opiTgWmaY7DX0H/+B1r6K6Tg64BvXYhhD+ShVHVdU0vIj7oMvLT5OPdIBFqk1wtlkG4b G0eiPMDFBf8NZsdmCdkSL8vw80EVcjJfeGLKpid+7f0y/zZTbcAgZ9y5ibio3uXvSI46 jyoeSWHvjVLfTKMUipCNT2kCx97J5p9Rcr8QXZIVRCEitkKtbEs9qjMvvVJO/p2d0rwc ldkk6YdzhMKWycWNdoaaVP8O6REhdqAYPhUL9WJaRLMLfdb7/Zwu2VS3l4VQXmxB9JH4 QvFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=Yujd7NYO/Gpv5hGCan+Hwvd6fcY54ztoBNLrmT1puBg=; b=QFWZYQIhuDCt/JTLY0JYXpJpfhtwTaiL/EZJkg+Yy3UBy0+PZ9vo5sqb2Ox+lpjbWC 3cyLIAvTEIBuV+7N1yUrcAma54cedQE6J82NTKCFXPxnlwK/LHfcuyvW7OU87ZqSq0IY u/dKccUwmLu0xErs0yeHUHMF2HJa7MwqH5aywE5Rfz4ee+vysOC0Ob1APBAhPuFTtgNw rnih5GT4jQBggiZxoRLe+xvqZIn4poeAdHYIeY1g2yxx6GdeuldX2oxRiGHOyyYzGzVE 3/5VhOxjmlCB/juupBHN6FvJdSo0Y17745T4tQlROoAK4Sn5GVhhqEpO48gMukvRC3qM 4zeQ== X-Gm-Message-State: APjAAAXGKI8bRi9B6Q5ry1/CtnI72S4TTb88v6IrnYrp85WVqM50bm/h ikAFKvF8rh+sHE2Bd0PqQGo8uSNhnksx X-Google-Smtp-Source: APXvYqztiY0Q4ZmmaSQYCImVDBFiPoKpJXtaMUoBTv6utaLXpsOu5sO8VaU8H9zbSEU0+Q8RUA3PyWHvcwVI X-Received: by 2002:a65:48cb:: with SMTP id o11mr37361408pgs.313.1579150763148; Wed, 15 Jan 2020 20:59:23 -0800 (PST) Date: Wed, 15 Jan 2020 20:59:18 -0800 Message-Id: <20200116045918.75597-1-brianvv@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.25.0.rc1.283.g88dfdc4193-goog Subject: [PATCH bpf-next] libbpf: Fix unneeded extra initialization in bpf_map_batch_common From: Brian Vazquez To: Brian Vazquez , Brian Vazquez , Alexei Starovoitov , Daniel Borkmann , "David S . Miller" Cc: Yonghong Song , Andrii Nakryiko , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Andrii Nakryiko Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org bpf_attr doesn't required to be declared with '= {}' as memset is used in the code. Fixes: 2ab3d86ea1859 ("libbpf: Add libbpf support to batch ops") Reported-by: Andrii Nakryiko Signed-off-by: Brian Vazquez --- tools/lib/bpf/bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/bpf/bpf.c b/tools/lib/bpf/bpf.c index 317727d612149..ed42b006533c4 100644 --- a/tools/lib/bpf/bpf.c +++ b/tools/lib/bpf/bpf.c @@ -457,7 +457,7 @@ static int bpf_map_batch_common(int cmd, int fd, void *in_batch, __u32 *count, const struct bpf_map_batch_opts *opts) { - union bpf_attr attr = {}; + union bpf_attr attr; int ret; if (!OPTS_VALID(opts, bpf_map_batch_opts)) -- 2.25.0.rc1.283.g88dfdc4193-goog