public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Clark Williams <williams@redhat.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	Jann Horn <jannh@google.com>, Andi Kleen <ak@linux.intel.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Michael Petlan <mpetlan@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Subject: [PATCH 06/12] libperf: Setup initial evlist::all_cpus value
Date: Thu, 16 Jan 2020 10:48:08 -0300	[thread overview]
Message-ID: <20200116134814.8811-7-acme@kernel.org> (raw)
In-Reply-To: <20200116134814.8811-1-acme@kernel.org>

From: Jiri Olsa <jolsa@kernel.org>

Jann Horn reported crash in perf ftrace because evlist::all_cpus isn't
initialized if there's evlist without events, which is the case for perf
ftrace.

Adding initial initialization of evlist::all_cpus from given cpus,
regardless of events in the evlist.

Fixes: 7736627b865d ("perf stat: Use affinity for closing file descriptors")
Reported-by: Jann Horn <jannh@google.com>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: Andi Kleen <ak@linux.intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Michael Petlan <mpetlan@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200110151537.153012-1-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/lib/perf/evlist.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c
index ae9e65aa2491..5b9f2ca50591 100644
--- a/tools/lib/perf/evlist.c
+++ b/tools/lib/perf/evlist.c
@@ -164,6 +164,9 @@ void perf_evlist__set_maps(struct perf_evlist *evlist,
 		evlist->threads = perf_thread_map__get(threads);
 	}
 
+	if (!evlist->all_cpus && cpus)
+		evlist->all_cpus = perf_cpu_map__get(cpus);
+
 	perf_evlist__propagate_maps(evlist);
 }
 
-- 
2.21.1


  parent reply	other threads:[~2020-01-16 13:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 13:48 [GIT PULL] perf/core improvements and fixes Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 01/12] perf clang: Fix build with Clang 9 Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 02/12] tools build: Fix test-clang.cpp with Clang 8+ Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 03/12] perf report: Clarify in help that --children is default Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 04/12] perf tools: Support --prefix/--prefix-strip Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 05/12] perf report: Fix no libunwind compiled warning break s390 issue Arnaldo Carvalho de Melo
2020-01-16 13:48 ` Arnaldo Carvalho de Melo [this message]
2020-01-16 13:48 ` [PATCH 07/12] perf tools: Use %define api.pure full instead of %pure-parser Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 08/12] perf ui gtk: Add missing zalloc object Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 09/12] perf/ui/gtk: Fix gtk2 build Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 10/12] perf beauty sockaddr: Fix augmented syscall format warning Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 11/12] perf c2c: Fix return type for histogram sorting comparision functions Arnaldo Carvalho de Melo
2020-01-16 13:48 ` [PATCH 12/12] perf header: Use last modification time for timestamp Arnaldo Carvalho de Melo
2020-01-20  8:23 ` [GIT PULL] perf/core improvements and fixes Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116134814.8811-7-acme@kernel.org \
    --to=acme@kernel.org \
    --cc=acme@redhat.com \
    --cc=ak@linux.intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=jannh@google.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mpetlan@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=williams@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox