From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACA6EC33CB1 for ; Thu, 16 Jan 2020 13:48:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82853208C3 for ; Thu, 16 Jan 2020 13:48:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579182527; bh=U9bGmkKu+y5sFzv7p1+FCXuR6nfik3QQK3h50RdP5WQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=i7S9+Ulfe9jGOqdiG7OryMhmfSJWDCvvtW/jLlFdLortzFtwdLMvmm7RrMgmVtuch 6tnIl6NCpEHj3Zz/wIOQS8BZiV1gYYLR2RtuSiG+VfgaOc3ZYl4nxFFzpK12u5JFrM lSpkY8fDDmtJwJmf7d0bjwJ8x/H/dWox38GlJobY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728978AbgAPNsq (ORCPT ); Thu, 16 Jan 2020 08:48:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:49978 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726958AbgAPNsp (ORCPT ); Thu, 16 Jan 2020 08:48:45 -0500 Received: from quaco.ghostprotocols.net (unknown [179.97.37.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C8EB92087E; Thu, 16 Jan 2020 13:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579182524; bh=U9bGmkKu+y5sFzv7p1+FCXuR6nfik3QQK3h50RdP5WQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NLZc7nr10Zqkx+w1JXuFDuKMYu0TZHokVPlIgnEXu9JxGcWlQQGscvUWLLFCVWfHp Z0Uxckqa6bVfiULRL2JUXkQxP1ODYBUKufw3KXzQ8rEQwQArJ9gIhqoqUYjjpmnSDU +0liGJTil0hFzRcMZgrwI4PEtrDx98Lncxor6p3g= From: Arnaldo Carvalho de Melo To: Ingo Molnar , Thomas Gleixner Cc: Jiri Olsa , Namhyung Kim , Clark Williams , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Jann Horn , Andi Kleen , Alexander Shishkin , Michael Petlan , Peter Zijlstra , Arnaldo Carvalho de Melo Subject: [PATCH 06/12] libperf: Setup initial evlist::all_cpus value Date: Thu, 16 Jan 2020 10:48:08 -0300 Message-Id: <20200116134814.8811-7-acme@kernel.org> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200116134814.8811-1-acme@kernel.org> References: <20200116134814.8811-1-acme@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jiri Olsa Jann Horn reported crash in perf ftrace because evlist::all_cpus isn't initialized if there's evlist without events, which is the case for perf ftrace. Adding initial initialization of evlist::all_cpus from given cpus, regardless of events in the evlist. Fixes: 7736627b865d ("perf stat: Use affinity for closing file descriptors") Reported-by: Jann Horn Signed-off-by: Jiri Olsa Acked-by: Andi Kleen Cc: Alexander Shishkin Cc: Michael Petlan Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lore.kernel.org/lkml/20200110151537.153012-1-jolsa@kernel.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/lib/perf/evlist.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/lib/perf/evlist.c b/tools/lib/perf/evlist.c index ae9e65aa2491..5b9f2ca50591 100644 --- a/tools/lib/perf/evlist.c +++ b/tools/lib/perf/evlist.c @@ -164,6 +164,9 @@ void perf_evlist__set_maps(struct perf_evlist *evlist, evlist->threads = perf_thread_map__get(threads); } + if (!evlist->all_cpus && cpus) + evlist->all_cpus = perf_cpu_map__get(cpus); + perf_evlist__propagate_maps(evlist); } -- 2.21.1