[PATCH RFC 0/3] x86/kvm/hyper-v: fix enlightened VMCS & QEMU4.2

Vitaly Kuznetsov
2020-01-15T17:10:30Z

With fine grained VMX feature enablement QEMU>=4.2 tries to do KVM_SET_MSRS
with default (matching CPU model) values and in case eVMCS is also enabled,
fails. While the regression is in QEMU, it may still be preferable to
fix this in KVM.

It would be great if we could just omit the VMX feature filtering in KVM
and make this guest's responsibility: if it switches to using enlightened
vmcs it should be aware that not all hardware features are going to be
supported. Genuine Hyper-V, however, fails the test. In particular, it
enables SECONDARY_EXEC_VIRTUALIZE_APIC_ACCESSES and without
'apic_access_addr' field in eVMCS there's not much we can do in KVM.

The suggested approach in this patch series is: move VMX feature
filtering to vmx_get_msr() so only guest doesn't see them when eVMCS
is enabled (PATCH2) and add a check that it doesn't enable them
(PATCH3).

I can't say that I'm a great fan of this workaround myself, thus RFC.

My initial RFC sent to qemu-devel@:
https://lists.nongnu.org/archive/html/qemu-devel/2020-01/msg00123.html

Vitaly Kuznetsov (3):
x86/kvm/hyper-v: remove stale evmcs_already_enabled check from
nested_enable_evmcs()
x86/kvm/hyper-v: move VMX controls sanitization out of
nested_enable_evmcs()
x86/kvm/hyper-v: don't allow to turn on unsupported VMX controls for
nested guests

arch/x86/kvm/vmx/evmcs.c | 99 ++++++++++++++++++++++++++++++++++-----
arch/x86/kvm/vmx/evmcs.h | 2 +
arch/x86/kvm/vmx/nested.c | 3 ++
arch/x86/kvm/vmx/vmx.c | 10 +++-
4 files changed, 100 insertions(+), 14 deletions(-)

--
2.24.1