From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F5BFC33CAF for ; Thu, 16 Jan 2020 17:02:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3985A2077B for ; Thu, 16 Jan 2020 17:02:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194176; bh=3oBM8iR31nVhILcxhG7RaXVRG4YqKplcZ0E43kxgmv4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=waHM47UP2sl1BaOeaVpODtNwlM1Hq8VEe/LC4f+C4fS3M9H7vTo19hhbN9e2NVDOK LV9N2aTHB5wlqHyjig9ut/U4zpR2guRklp65w+4PFAsZKR7yZKNztUFJ9tf92JwQDp 5V+ej2rxYzDuZ3SZFqd66W2WFyzUR27emJg4nL/I= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388512AbgAPRCz (ORCPT ); Thu, 16 Jan 2020 12:02:55 -0500 Received: from mail.kernel.org ([198.145.29.99]:56148 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729819AbgAPRCs (ORCPT ); Thu, 16 Jan 2020 12:02:48 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 723D72467C; Thu, 16 Jan 2020 17:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194168; bh=3oBM8iR31nVhILcxhG7RaXVRG4YqKplcZ0E43kxgmv4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wf7cHwujKkt8YrX8yDjC8hEOaKhClZLHGCDrtoUyL5YbxqwSmrczlqkNvdfSHL2Dc j3U3pmWw7ETJgwSSpTnMThOtQPJYAcw02HuMYlkXzDnjow7IRB1d6oBTIg4GenLxZv /t880PdhUbLDJNGmv1y0ZwH//zYGtiHTlZyOaDgU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 248/671] media: ivtv: update *pos correctly in ivtv_read_pos() Date: Thu, 16 Jan 2020 11:52:37 -0500 Message-Id: <20200116165940.10720-131-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165940.10720-1-sashal@kernel.org> References: <20200116165940.10720-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit f8e579f3ca0973daef263f513da5edff520a6c0d ] We had intended to update *pos, but the current code is a no-op. Fixes: 1a0adaf37c30 ("V4L/DVB (5345): ivtv driver for Conexant cx23416/cx23415 MPEG encoder/decoder") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/pci/ivtv/ivtv-fileops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ivtv/ivtv-fileops.c b/drivers/media/pci/ivtv/ivtv-fileops.c index 6196daae4b3e..043ac0ae9ed0 100644 --- a/drivers/media/pci/ivtv/ivtv-fileops.c +++ b/drivers/media/pci/ivtv/ivtv-fileops.c @@ -420,7 +420,7 @@ static ssize_t ivtv_read_pos(struct ivtv_stream *s, char __user *ubuf, size_t co IVTV_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc); if (rc > 0) - pos += rc; + *pos += rc; return rc; } -- 2.20.1