From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C27A1C33CAF for ; Thu, 16 Jan 2020 17:03:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 90F7420730 for ; Thu, 16 Jan 2020 17:03:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194224; bh=0sOUfuaGCRPeaY77jrD259i3y62WK0oAolMW1IHHZUw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fcMSKYBKNYWVyUL8gSpM16khCsx1nQRje1IfMRigcUbLYgCmQWu7u9isBTyf1ROQl DosSQU2AEA4AuAHSs12e4G7KTNCu8TuiUCVG8IDCabHvllrWZ5xOv+UW6wCowqX6tL mi90DDy14LmWt6qFYaxkLYMaoAWmZgNgjvRTIWIk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388528AbgAPRDA (ORCPT ); Thu, 16 Jan 2020 12:03:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:56264 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388491AbgAPRCv (ORCPT ); Thu, 16 Jan 2020 12:02:51 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 796F92077B; Thu, 16 Jan 2020 17:02:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194171; bh=0sOUfuaGCRPeaY77jrD259i3y62WK0oAolMW1IHHZUw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=x2d3rkZELqOrX7tTQVl+L5z8bZyDk2OwMQ6P63CMWXxrsLhvVaJIVqPBk7pUAE+Ms EfGnWXTTMpAL7c+W9nj4OBpDsyuFZyz97yqx732JKI+CW2KDIUa2DjkuKbgzSnzkLV newZ5DHSt0cMgNFSIqaew77rwRx0fA6dYidwkrHY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab , Sasha Levin , linux-media@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 250/671] media: wl128x: Fix an error code in fm_download_firmware() Date: Thu, 16 Jan 2020 11:52:39 -0500 Message-Id: <20200116165940.10720-133-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165940.10720-1-sashal@kernel.org> References: <20200116165940.10720-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit ef4bb63dc1f7213c08e13f6943c69cd27f69e4a3 ] We forgot to set "ret" on this error path. Fixes: e8454ff7b9a4 ("[media] drivers:media:radio: wl128x: FM Driver Common sources") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Sasha Levin --- drivers/media/radio/wl128x/fmdrv_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c index 1cf4019689a5..cccf1a743f4e 100644 --- a/drivers/media/radio/wl128x/fmdrv_common.c +++ b/drivers/media/radio/wl128x/fmdrv_common.c @@ -1271,8 +1271,9 @@ static int fm_download_firmware(struct fmdev *fmdev, const u8 *fw_name) switch (action->type) { case ACTION_SEND_COMMAND: /* Send */ - if (fmc_send_cmd(fmdev, 0, 0, action->data, - action->size, NULL, NULL)) + ret = fmc_send_cmd(fmdev, 0, 0, action->data, + action->size, NULL, NULL); + if (ret) goto rel_fw; cmd_cnt++; -- 2.20.1