From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE5FAC33CAF for ; Thu, 16 Jan 2020 19:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9143C2073A for ; Thu, 16 Jan 2020 19:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579201839; bh=HFqQ0W3JycSYWn+f+r/CWjUm8NUhLCFnWIxVqNKY35k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FtqIIyIMhw0epNq5K/MrKH2Ks2QMrZSp0Mpwdz6Ff9IKqQVsJJ3Js2pRuubixN09F AALzqm4Jecxn3q2nS5YWUzGjpUUUhFzoevZ8zzlCN5RmuWEojpkqr1llrugUYFACBA uMACsnBzzAKc+Il7WQArzOPJbfpMYOvMAaOYdvC8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387781AbgAPRA0 (ORCPT ); Thu, 16 Jan 2020 12:00:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:49836 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387724AbgAPRAT (ORCPT ); Thu, 16 Jan 2020 12:00:19 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F0F720728; Thu, 16 Jan 2020 17:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194019; bh=HFqQ0W3JycSYWn+f+r/CWjUm8NUhLCFnWIxVqNKY35k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MQDKTi6LWis57Y60hNL4/T6zVlJuVHu3LGO/kKIY9Q0FbgbCx86OtbgOpe588/+f6 5YA6YzAY/OnnS8AkaDp2RkN4xOYZv9SeCeuSdal8FS+8bFvJSfblp3h6PffloZ07Vs pW6Lb3ruCTMsGHXADZMcENbuFKaE5O54vp8GAvCU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Liu Jian , Hamish Martin , Greg Kroah-Hartman , Sasha Levin Subject: [PATCH AUTOSEL 4.19 140/671] driver: uio: fix possible use-after-free in __uio_register_device Date: Thu, 16 Jan 2020 11:50:49 -0500 Message-Id: <20200116165940.10720-23-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116165940.10720-1-sashal@kernel.org> References: <20200116165940.10720-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Liu Jian [ Upstream commit 221a1f4ac12d2ab46246c160b2e00d1b1160d5d9 ] In uio_dev_add_attributes() error handing case, idev is used after device_unregister(), in which 'idev' has been released, touch idev cause use-after-free. Fixes: a93e7b331568 ("uio: Prevent device destruction while fds are open") Signed-off-by: Liu Jian Reviewed-by: Hamish Martin Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/uio/uio.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c index e4b418757017..9c788748bdc6 100644 --- a/drivers/uio/uio.c +++ b/drivers/uio/uio.c @@ -943,6 +943,7 @@ int __uio_register_device(struct module *owner, return ret; } + device_initialize(&idev->dev); idev->dev.devt = MKDEV(uio_major, idev->minor); idev->dev.class = &uio_class; idev->dev.parent = parent; @@ -953,7 +954,7 @@ int __uio_register_device(struct module *owner, if (ret) goto err_device_create; - ret = device_register(&idev->dev); + ret = device_add(&idev->dev); if (ret) goto err_device_create; @@ -985,9 +986,10 @@ int __uio_register_device(struct module *owner, err_request_irq: uio_dev_del_attributes(idev); err_uio_dev_add_attributes: - device_unregister(&idev->dev); + device_del(&idev->dev); err_device_create: uio_free_minor(idev); + put_device(&idev->dev); return ret; } EXPORT_SYMBOL_GPL(__uio_register_device); -- 2.20.1