From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CAF5C33CAF for ; Thu, 16 Jan 2020 18:49:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3A69F2073A for ; Thu, 16 Jan 2020 18:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579200580; bh=d7dmRKmohAvZ7kcE70HwAppkH5lbpOz49xer5jIKRIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=VBcsjUs9mbEl3tzuq99icfssrUAAxGOd2n68F6ys6Nbb9fqxW2m8e+12wtq/Hu1lH czhsRZs7azrAZ3XxX5P1TsA5YFuGf7LCmC8v7D36gcahRyhCqL+XsQhZ4TNPuf0RI4 /uc0ARoHm2oOM6SZU/3MEqEHrO8vTKayuaolp0Tw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437047AbgAPStj (ORCPT ); Thu, 16 Jan 2020 13:49:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:45134 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389073AbgAPRJV (ORCPT ); Thu, 16 Jan 2020 12:09:21 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45837205F4; Thu, 16 Jan 2020 17:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194561; bh=d7dmRKmohAvZ7kcE70HwAppkH5lbpOz49xer5jIKRIc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yN9UDlRJ1GODHpPtJ7ilaeoJJk2vaHr9fFbE8PzQA1YnzQYBLuOqiCsM3r9oQ/K3k Fhwa7Bo7Kwh7D6UXIXYAeIcvELkepujhoKqZw2gRHBxvTPp2dufmWc0klgkBtocHaT U+yP9/1ZpCK5hv8B1WECx+SWqzUs4BXQdZzC6yxQ= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Michael Chan , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 441/671] bnxt_en: Suppress error messages when querying DSCP DCB capabilities. Date: Thu, 16 Jan 2020 12:01:19 -0500 Message-Id: <20200116170509.12787-178-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michael Chan [ Upstream commit 4ca5fa39e1aea2f85eb9c4257075c4077c6531da ] Some firmware versions do not support this so use the silent variant to send the message to firmware to suppress the harmless error. This error message is unnecessarily alarming the user. Fixes: afdc8a84844a ("bnxt_en: Add DCBNL DSCP application protocol support.") Signed-off-by: Michael Chan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c index a85d2be986af..0e4e0b47f5d8 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c @@ -396,7 +396,7 @@ static int bnxt_hwrm_queue_dscp_qcaps(struct bnxt *bp) bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_QUEUE_DSCP_QCAPS, -1, -1); mutex_lock(&bp->hwrm_cmd_lock); - rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); + rc = _hwrm_send_message_silent(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); if (!rc) { bp->max_dscp_value = (1 << resp->num_dscp_bits) - 1; if (bp->max_dscp_value < 0x3f) -- 2.20.1