From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9F8DC33CAF for ; Thu, 16 Jan 2020 18:43:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B15A02081E for ; Thu, 16 Jan 2020 18:43:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579200207; bh=hHuk0naSNm8WN8GbfxGfbUUDOXEIo3+eCFwDtWGPcrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=obu4u9qhQxwEi8I+xJb0TTPvI6diy2PPNo403evkpkqUqeZgDjQoHU63dp4Gnt2g6 ktRG4E5KXvJCSgYsrQ+iVLWs905JPfy4U6r4pDUHQ1xxTq8UQ02ba+WjqhwRYV/pWJ ILAvciHZfAbBqukoWJqZISspm+AgMjDVBHzfmWTw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389738AbgAPSn1 (ORCPT ); Thu, 16 Jan 2020 13:43:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:51574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390198AbgAPRLR (ORCPT ); Thu, 16 Jan 2020 12:11:17 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2351A21D56; Thu, 16 Jan 2020 17:11:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194676; bh=hHuk0naSNm8WN8GbfxGfbUUDOXEIo3+eCFwDtWGPcrI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PQNj0SVAfNhrDTwZDm8DDntsxSIt9gBoDkUoX75FsMAGRPcHA32MGb+fkf7P/yMFw XSGGnDOwclvHT+FKQmPiweiMCGM9Mh1bwrmIrVjqFxwNpZ0rJABUGxMs9mbA+fw6Lk 0hob0VT/+KbnQz0HHYp2PJLtFegD4f2Awp87h9CU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Colin Ian King , Alexandru Ardelean , Jonathan Cameron , Sasha Levin , linux-iio@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 523/671] iio: dac: ad5380: fix incorrect assignment to val Date: Thu, 16 Jan 2020 12:02:41 -0500 Message-Id: <20200116170509.12787-260-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin Ian King [ Upstream commit b1e18768ef1214c0a8048327918a182cabe09f9d ] Currently the pointer val is being incorrectly incremented instead of the value pointed to by val. Fix this by adding in the missing * indirection operator. Addresses-Coverity: ("Unused value") Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver") Signed-off-by: Colin Ian King Reviewed-by: Alexandru Ardelean Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/dac/ad5380.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c index 873c2bf637c0..617c9f7fe59a 100644 --- a/drivers/iio/dac/ad5380.c +++ b/drivers/iio/dac/ad5380.c @@ -221,7 +221,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev, if (ret) return ret; *val >>= chan->scan_type.shift; - val -= (1 << chan->scan_type.realbits) / 2; + *val -= (1 << chan->scan_type.realbits) / 2; return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: *val = 2 * st->vref; -- 2.20.1