From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AC3EC33CB6 for ; Thu, 16 Jan 2020 17:11:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 57D7D24692 for ; Thu, 16 Jan 2020 17:11:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194704; bh=0a+6w6SG03FCjdjf/SOOSVff7mcP52e5n90AJXyPAjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YxQDOCwuX1tP3NKDMcZkHQ3RnmhjDGQewUmdQxcExhSJV5tz1gn+t57Ez6F/Tzmx1 6zJ6yVPCxR5zJqDtvHaEnmpGKdLMWf+WpSEX6BT9F/6Tko7WOV2n7vGugn2taSGPta XqLs2McSSHIjz13M+s8W1pNjFu76OoMzgbcT2AOs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390301AbgAPRLn (ORCPT ); Thu, 16 Jan 2020 12:11:43 -0500 Received: from mail.kernel.org ([198.145.29.99]:52400 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390260AbgAPRLd (ORCPT ); Thu, 16 Jan 2020 12:11:33 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B00B92468F; Thu, 16 Jan 2020 17:11:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194692; bh=0a+6w6SG03FCjdjf/SOOSVff7mcP52e5n90AJXyPAjQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nuOkIJGPppRvzIeS5EcggoKKMcLUBZMRvi7Q58+huG0XS3Oh30JS9Ef4kANGW2V/G QFzD3JPTsoEF27fRDi/lzQXuVaYwuQrlqAhMEmumso8ETF/3EvJo+Puf7SO/Vd6WFQ bzO8Pk5099wyq0lBRmJGK8q9owfvAlqEDM3NM0cY= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Wei Yongjun , Kalle Valo , Sasha Levin , linux-wireless@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 534/671] rtlwifi: Fix file release memory leak Date: Thu, 16 Jan 2020 12:02:52 -0500 Message-Id: <20200116170509.12787-271-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun [ Upstream commit 4c3e48794dec7cb568974ba3bf2ab62b9c45ca3e ] When using single_open() for opening, single_release() should be used instead of seq_release(), otherwise there is a memory leak. This is detected by Coccinelle semantic patch. Fixes: 610247f46feb ("rtlwifi: Improve debugging by using debugfs") Signed-off-by: Wei Yongjun Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtlwifi/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/debug.c b/drivers/net/wireless/realtek/rtlwifi/debug.c index d70385be9976..498994041bbc 100644 --- a/drivers/net/wireless/realtek/rtlwifi/debug.c +++ b/drivers/net/wireless/realtek/rtlwifi/debug.c @@ -109,7 +109,7 @@ static const struct file_operations file_ops_common = { .open = dl_debug_open_common, .read = seq_read, .llseek = seq_lseek, - .release = seq_release, + .release = single_release, }; static int rtl_debug_get_mac_page(struct seq_file *m, void *v) -- 2.20.1