From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67445C33CAF for ; Thu, 16 Jan 2020 18:39:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3FB59207E0 for ; Thu, 16 Jan 2020 18:39:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579199986; bh=6qCs0Tzxgc3wJtYtfYBsByJSiSkeMGo4KBX8tHMMJlI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=eozslclRguJNM2Ijp0qodCIOK0phy+6uFnlQopxz20hrtK/3sKgK5xyiJBQtCM9OG QLhGkQ4PtkY/8zJSyY96i/SmzJWLGeRpIBPPfNfCkLFdKWXaYqhJq8BZwSnMi/aEx+ wrbUloV2McivoYxfx4wwikxiORk+b/H/6pmAtQos= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406414AbgAPSjo (ORCPT ); Thu, 16 Jan 2020 13:39:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:54422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390404AbgAPRML (ORCPT ); Thu, 16 Jan 2020 12:12:11 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5FD5124694; Thu, 16 Jan 2020 17:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194731; bh=6qCs0Tzxgc3wJtYtfYBsByJSiSkeMGo4KBX8tHMMJlI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Rwr3ceSe+/WGcm0SJlS7x3A5ADjYkO+y73HG1B/dhnEqnS5iqsAInjoRYmw/P7K4s NxJrOn67G5eZmx+WfcKd3s5VfD0ePbNYQSyRXzUcjsE44uaNY5OmgjWLsCIzvo4sNH Y8VCW4/S5I2iDal+l9Iy7FLpP+YCWNOQ7NcpJAtI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Florian Fainelli , "David S . Miller" , Sasha Levin , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 564/671] net: broadcom/bcmsysport: Fix signedness in bcm_sysport_probe() Date: Thu, 16 Jan 2020 12:03:22 -0500 Message-Id: <20200116170509.12787-301-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 25a584955f020d6ec499c513923fb220f3112d2b ] The "priv->phy_interface" variable is an enum and in this context GCC will treat it as unsigned so the error handling will never be triggered. Fixes: 80105befdb4b ("net: systemport: add Broadcom SYSTEMPORT Ethernet MAC driver") Signed-off-by: Dan Carpenter Acked-by: Florian Fainelli Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bcmsysport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c index 0bdbc72605e1..49aa3b5ea57c 100644 --- a/drivers/net/ethernet/broadcom/bcmsysport.c +++ b/drivers/net/ethernet/broadcom/bcmsysport.c @@ -2470,7 +2470,7 @@ static int bcm_sysport_probe(struct platform_device *pdev) priv->phy_interface = of_get_phy_mode(dn); /* Default to GMII interface mode */ - if (priv->phy_interface < 0) + if ((int)priv->phy_interface < 0) priv->phy_interface = PHY_INTERFACE_MODE_GMII; /* In the case of a fixed PHY, the DT node associated -- 2.20.1