From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92B0C33CAF for ; Thu, 16 Jan 2020 18:39:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 778732073A for ; Thu, 16 Jan 2020 18:39:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579199965; bh=i8Mc8ktcBWCOaWcwPEM9+Ic2PxDRqnufU9bUQ91cDN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=yijePlOnEXly6q9mgCP1vPJWIRrWBeGpMe78+gFdukfZ6bRzubc89ZZ7/Xy9S09vo cKmZ/SXFJUsiBELiupYiNDhTH6VTyjGflXIHXLaSj2ifvA3kpnaTS+5kXxmBQN458y wXFhPc88jSDr+aXk8NpAm4ViMmnXTsv+EOOiSqos= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407203AbgAPSjY (ORCPT ); Thu, 16 Jan 2020 13:39:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:54662 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390434AbgAPRMR (ORCPT ); Thu, 16 Jan 2020 12:12:17 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29AE824690; Thu, 16 Jan 2020 17:12:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194737; bh=i8Mc8ktcBWCOaWcwPEM9+Ic2PxDRqnufU9bUQ91cDN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=op17xVgCJ1r5EIE5IyW3320APFQMEWp9sVJ/cf3u2Fr50RQD29e4qMlfFZJe3U7wa 69PpZDCCNqk/e1VAYYrseupyw8uTCPJV7uQRL6M8EERLUsYTjJrS+l7cL+7Asam+jI uBGC2b03muE/5kO2vi9slKebHv0llscBuhWf74NM= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Radhey Shyam Pandey , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.19 568/671] net: axienet: fix a signedness bug in probe Date: Thu, 16 Jan 2020 12:03:26 -0500 Message-Id: <20200116170509.12787-305-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 73e211e11be86715d66bd3c9d38b3c34b05fca9a ] The "lp->phy_mode" is an enum but in this context GCC treats it as an unsigned int so the error handling is never triggered. Fixes: ee06b1728b95 ("net: axienet: add support for standard phy-mode binding") Signed-off-by: Dan Carpenter Reviewed-by: Radhey Shyam Pandey Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/xilinx/xilinx_axienet_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c index 28764268a44f..b093f14eeec3 100644 --- a/drivers/net/ethernet/xilinx/xilinx_axienet_main.c +++ b/drivers/net/ethernet/xilinx/xilinx_axienet_main.c @@ -1573,7 +1573,7 @@ static int axienet_probe(struct platform_device *pdev) } } else { lp->phy_mode = of_get_phy_mode(pdev->dev.of_node); - if (lp->phy_mode < 0) { + if ((int)lp->phy_mode < 0) { ret = -EINVAL; goto free_netdev; } -- 2.20.1