From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 339E0C33CAF for ; Thu, 16 Jan 2020 18:57:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EC29D2072E for ; Thu, 16 Jan 2020 18:57:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579201075; bh=EocPaQWXVOp3dvQfmAhf1SXHcrGs+GXWeZoga7K4z/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=NQv8gYNrq3CyL6qnPaWzogorzBDlFKcfltQkY0JgdXMi3xCQcuOfj76fB8zOt2afg SwOzUBmhD1+nt6g4+XL7uzGeF7TrXxT2HCOscu3LuniYTxY0yvpja3bfSaPE2ft460 3nxC6xRlcH8DIcgb7IPxwYEbo8qKuUZQZcKzOnEc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437157AbgAPS5x (ORCPT ); Thu, 16 Jan 2020 13:57:53 -0500 Received: from mail.kernel.org ([198.145.29.99]:37974 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389035AbgAPRG4 (ORCPT ); Thu, 16 Jan 2020 12:06:56 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0161C20663; Thu, 16 Jan 2020 17:06:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194416; bh=EocPaQWXVOp3dvQfmAhf1SXHcrGs+GXWeZoga7K4z/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VbrQXV1KQKfkM3gqBrHZLwRk8WGXwOGXJNfnTg6j2PN98osBeZIoYprhw90Q1Y4vz gAR3TNYLZ5dIh/AXk8Qm+Zhbhftxalojk0VzJN77Zt5R8BHbZTLrdRrlplbU5X92+6 DGG/mPZNkwYCjgsQ/yESJP76L4Rjn7FCMKezEVsE= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Igor Konopko , =?UTF-8?q?Javier=20Gonz=C3=A1lez?= , Hans Holmberg , =?UTF-8?q?Matias=20Bj=C3=B8rling?= , Jens Axboe , Sasha Levin , linux-block@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 337/671] lightnvm: pblk: fix lock order in pblk_rb_tear_down_check Date: Thu, 16 Jan 2020 11:59:35 -0500 Message-Id: <20200116170509.12787-74-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Igor Konopko [ Upstream commit 486b5aac85f6ec0b2df3e82a6a629d5eb7804db5 ] In pblk_rb_tear_down_check() the spinlock functions are not called in proper order. Fixes: a4bd217 ("lightnvm: physical block device (pblk) target") Signed-off-by: Igor Konopko Reviewed-by: Javier González Reviewed-by: Hans Holmberg Signed-off-by: Matias Bjørling Signed-off-by: Jens Axboe Signed-off-by: Sasha Levin --- drivers/lightnvm/pblk-rb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c index f6eec0212dfc..d22c13b55622 100644 --- a/drivers/lightnvm/pblk-rb.c +++ b/drivers/lightnvm/pblk-rb.c @@ -784,8 +784,8 @@ int pblk_rb_tear_down_check(struct pblk_rb *rb) } out: - spin_unlock(&rb->w_lock); spin_unlock_irq(&rb->s_lock); + spin_unlock(&rb->w_lock); return ret; } -- 2.20.1