From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FE31C33CB3 for ; Thu, 16 Jan 2020 17:19:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE54A246BD for ; Thu, 16 Jan 2020 17:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195174; bh=s5OT3QgBBK+goTpxE8YW0rfI2jKP3hKffdvRlCnkh5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HUSK8Hz1iboyzovbds2qUKAexeeyCNNPqtu71oOTDpXD8l2izGH5IsMGicutYVkxK i962Nr7aZGB4SUuinYin6iwWQCrrjJsGG7q3ZvIvU1ERq+6Giw4MLgsqpILSXxUxC9 FJ1l9kCO3xSgyNYDGzCkwC/y/ORVvIAz/zU7xitE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733287AbgAPRSZ (ORCPT ); Thu, 16 Jan 2020 12:18:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:45168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391405AbgAPRSO (ORCPT ); Thu, 16 Jan 2020 12:18:14 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2C62E20728; Thu, 16 Jan 2020 17:18:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195094; bh=s5OT3QgBBK+goTpxE8YW0rfI2jKP3hKffdvRlCnkh5w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ogBaAi6WKtyNOs7UZumfI6QGujzWQhHGsl9W0YEIixgAIb5LKd6h+V2sBac0AFIHP tI6kdJ2Y3N3YKNZsaFwXYKOm4XOJiEGbdHZkKJ6ltEFtzLJZEKqjdmlV9D9by5lFaD 1N/w3S7gGkK9oEaqKRot4gTHvTBZKkZzv/nsiXB0= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yangtao Li , Stephen Boyd , Sasha Levin , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 4.14 040/371] clk: imx6q: fix refcount leak in imx6q_clocks_init() Date: Thu, 16 Jan 2020 12:11:48 -0500 Message-Id: <20200116171719.16965-40-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116171719.16965-1-sashal@kernel.org> References: <20200116171719.16965-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yangtao Li [ Upstream commit c9ec1d8fef31b5fc9e90e99f9bd685db5caa7c5e ] The of_find_compatible_node() returns a node pointer with refcount incremented, but there is the lack of use of the of_node_put() when done. Add the missing of_node_put() to release the refcount. Signed-off-by: Yangtao Li Fixes: 2acd1b6f889c ("ARM: i.MX6: implement clocks using common clock framework") Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/imx/clk-imx6q.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c index 8eb93eb2f857..e0547654cb7b 100644 --- a/drivers/clk/imx/clk-imx6q.c +++ b/drivers/clk/imx/clk-imx6q.c @@ -431,6 +431,7 @@ static void __init imx6q_clocks_init(struct device_node *ccm_node) np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-anatop"); anatop_base = base = of_iomap(np, 0); WARN_ON(!base); + of_node_put(np); /* Audio/video PLL post dividers do not work on i.MX6q revision 1.0 */ if (clk_on_imx6q() && imx_get_soc_revision() == IMX_CHIP_REVISION_1_0) { -- 2.20.1