From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07D55C33CAF for ; Thu, 16 Jan 2020 17:19:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C1E922467A for ; Thu, 16 Jan 2020 17:19:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195165; bh=Y89DntmdLJBUYHynvLLmDTJ4+cBSFegH8ylUeW2/lQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zefaZby2zACTSlDg6OfnXgXbCiQUjxLl4ajfSGoXgRU98vko0Q8Gfe22esKOu7EDo dTX/xWfzdfcuIo9ajFBFngA1YUc1rqwa88Ym/+7UGs4oftZnFxAZb45zAh4CCwdVPJ ppwNvcXEE/D+86HJ4lCI0vlA0dR/b8k2J9MxLbhc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391506AbgAPRTY (ORCPT ); Thu, 16 Jan 2020 12:19:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:45980 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391472AbgAPRS2 (ORCPT ); Thu, 16 Jan 2020 12:18:28 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F61D246B1; Thu, 16 Jan 2020 17:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195108; bh=Y89DntmdLJBUYHynvLLmDTJ4+cBSFegH8ylUeW2/lQc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZKxiqBMeCZG0P5C34C/qK8Cxmyx+jIzztlTkJ2k/LyDY67TeADprTamxzMsfvcz9E GuF5mpQDs58y3puR3S424DkfVvir+xWif0bVOQzhAgpq4A1VzWTqrSkyzS4q929JdG AootbgOQdV92weP1AuSupVncBRL/iiW+zq8YA2os= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Gal Pressman , Parvi Kaustubhi , Jason Gunthorpe , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 050/371] IB/usnic: Fix out of bounds index check in query pkey Date: Thu, 16 Jan 2020 12:11:58 -0500 Message-Id: <20200116171719.16965-50-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116171719.16965-1-sashal@kernel.org> References: <20200116171719.16965-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Gal Pressman [ Upstream commit 4959d5da5737dd804255c75b8cea0a2929ce279a ] The pkey table size is one element, index should be tested for > 0 instead of > 1. Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver") Signed-off-by: Gal Pressman Acked-by: Parvi Kaustubhi Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c index fdfa25059723..2602c7375d58 100644 --- a/drivers/infiniband/hw/usnic/usnic_ib_verbs.c +++ b/drivers/infiniband/hw/usnic/usnic_ib_verbs.c @@ -423,7 +423,7 @@ struct net_device *usnic_get_netdev(struct ib_device *device, u8 port_num) int usnic_ib_query_pkey(struct ib_device *ibdev, u8 port, u16 index, u16 *pkey) { - if (index > 1) + if (index > 0) return -EINVAL; *pkey = 0xffff; -- 2.20.1