From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0679C33CB6 for ; Thu, 16 Jan 2020 18:25:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7501F2051A for ; Thu, 16 Jan 2020 18:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579199111; bh=hPdpzb2Hw4A3ySqBPZNJLG7GDoLkemO8rz+yCgpALys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ilh6/srrgkZliPp7GgAKUm0m5Bhcxpvy/CV8lRZJ+9xImMAiE5BxMWeoaXtv7HSYC bYMdGOZwVpjv+3rlm3y4Jw1m7QRvC32HNIApcnZNYPhvSm0rl0yZM6ybuoPOdbozOI Oe9fQl4qhvrKMnL8Z3PVlaZdUKaYUpfkgpW6SAlY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436651AbgAPSZK (ORCPT ); Thu, 16 Jan 2020 13:25:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:36544 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392397AbgAPR1F (ORCPT ); Thu, 16 Jan 2020 12:27:05 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 47168246D4; Thu, 16 Jan 2020 17:27:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195625; bh=hPdpzb2Hw4A3ySqBPZNJLG7GDoLkemO8rz+yCgpALys=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CHa2k5HCNA8/RUWuQyu2mzH3lizmkRGfQDEe0wtNIBfBWYhYnnIZ7zn4EhM9VYkI7 sLvSUcZGy4wo8aJAgwFuOQN/Bo+kaNoh7jKWgPyZVA+2MWmUpIQw+VAlmbMcj1FloV Da3V4UjVx7ZkA0n2pSy3fdS/4blemgoo2wRj01KU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Dan Carpenter , Mario Limonciello , Andy Shevchenko , Sasha Levin , platform-driver-x86@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 195/371] platform/x86: alienware-wmi: printing the wrong error code Date: Thu, 16 Jan 2020 12:21:07 -0500 Message-Id: <20200116172403.18149-138-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit 6d1f8b3d75419a8659ac916a1e9543bb3513a882 ] The "out_data" variable is uninitialized at the point. Originally, this used to print "status" instead and that seems like the correct thing to print. Fixes: bc2ef884320b ("alienware-wmi: For WMAX HDMI method, introduce a way to query HDMI cable status") Signed-off-by: Dan Carpenter Reviewed-by: Mario Limonciello Signed-off-by: Andy Shevchenko Signed-off-by: Sasha Levin --- drivers/platform/x86/alienware-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/alienware-wmi.c b/drivers/platform/x86/alienware-wmi.c index cbd84e2e3bd4..2c82188f8486 100644 --- a/drivers/platform/x86/alienware-wmi.c +++ b/drivers/platform/x86/alienware-wmi.c @@ -570,7 +570,7 @@ static ssize_t show_hdmi_source(struct device *dev, return scnprintf(buf, PAGE_SIZE, "input [gpu] unknown\n"); } - pr_err("alienware-wmi: unknown HDMI source status: %d\n", out_data); + pr_err("alienware-wmi: unknown HDMI source status: %u\n", status); return scnprintf(buf, PAGE_SIZE, "input gpu [unknown]\n"); } -- 2.20.1