From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A69BC33CB3 for ; Thu, 16 Jan 2020 18:31:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B1B2206D9 for ; Thu, 16 Jan 2020 18:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579199462; bh=KT9eY9teyu9DbO7QxqE4c0V0TOwHiCWLRLe30T59hJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HGH4Sh388hc508LPQEZ6zWSUDI4xQZKPwUkMnBJQfS3Uf8gKJQpACBTpQDBJnTlC+ eRZ8cc5gGEEnAXegwubDSguqcjbAv+8P8ijVwLgNtfIY3FNFubcRsTznin5E45mcQJ s2yGVbxGnYfkFmG44QkvwM+361qYroxGxfD123fA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391066AbgAPRZ0 (ORCPT ); Thu, 16 Jan 2020 12:25:26 -0500 Received: from mail.kernel.org ([198.145.29.99]:60628 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391888AbgAPRZI (ORCPT ); Thu, 16 Jan 2020 12:25:08 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8230246A5; Thu, 16 Jan 2020 17:25:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579195507; bh=KT9eY9teyu9DbO7QxqE4c0V0TOwHiCWLRLe30T59hJU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=An2pNbbAGZWbBKKWs5XrjgXKwDZYu6MdZxHa8OTAU0CvRs+pHuqYVkSoDTdhVv3CE R3V9ydJBYq/gcfuu6LamFkYSQDABgX7pT0AxlBu6D3942VKJQQyU44zIFK6vSai5Yj RS85KvhX7cQ5WCvLNqNb0WlGJ6Fq4a4VoUscQAtk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Axel Lin , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.14 107/371] regulator: pv88060: Fix array out-of-bounds access Date: Thu, 16 Jan 2020 12:19:39 -0500 Message-Id: <20200116172403.18149-50-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116172403.18149-1-sashal@kernel.org> References: <20200116172403.18149-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Axel Lin [ Upstream commit 7cd415f875591bc66c5ecb49bf84ef97e80d7b0e ] Fix off-by-one while iterating current_limits array. The valid index should be 0 ~ n_current_limits -1. Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver") Signed-off-by: Axel Lin Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/pv88060-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pv88060-regulator.c b/drivers/regulator/pv88060-regulator.c index a9446056435f..1f2d8180506b 100644 --- a/drivers/regulator/pv88060-regulator.c +++ b/drivers/regulator/pv88060-regulator.c @@ -135,7 +135,7 @@ static int pv88060_set_current_limit(struct regulator_dev *rdev, int min, int i; /* search for closest to maximum */ - for (i = info->n_current_limits; i >= 0; i--) { + for (i = info->n_current_limits - 1; i >= 0; i--) { if (min <= info->current_limits[i] && max >= info->current_limits[i]) { return regmap_update_bits(rdev->regmap, -- 2.20.1