public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Petr Machata <petrm@mellanox.com>,
	Ido Schimmel <idosch@mellanox.com>,
	"David S . Miller" <davem@davemloft.net>,
	Sasha Levin <sashal@kernel.org>,
	netdev@vger.kernel.org
Subject: [PATCH AUTOSEL 4.9 009/251] mlxsw: reg: QEEC: Add minimum shaper fields
Date: Thu, 16 Jan 2020 12:30:43 -0500	[thread overview]
Message-ID: <20200116173445.21385-9-sashal@kernel.org> (raw)
In-Reply-To: <20200116173445.21385-1-sashal@kernel.org>

From: Petr Machata <petrm@mellanox.com>

[ Upstream commit 8b931821aa04823e2e5df0ae93937baabbd23286 ]

Add QEEC.mise (minimum shaper enable) and QEEC.min_shaper_rate to enable
configuration of minimum shaper.

Increase the QEEC length to 0x20 as well: that's the length that the
register has had for a long time now, but with the configurations that
mlxsw typically exercises, the firmware tolerated 0x1C-sized packets.
With mise=true however, FW rejects packets unless they have the full
required length.

Fixes: b9b7cee40579 ("mlxsw: reg: Add QoS ETS Element Configuration register")
Signed-off-by: Petr Machata <petrm@mellanox.com>
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
 drivers/net/ethernet/mellanox/mlxsw/reg.h | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/reg.h b/drivers/net/ethernet/mellanox/mlxsw/reg.h
index b2a745b579fd..fdc69218c8ca 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/reg.h
+++ b/drivers/net/ethernet/mellanox/mlxsw/reg.h
@@ -1873,7 +1873,7 @@ static inline void mlxsw_reg_qtct_pack(char *payload, u8 local_port,
  * Configures the ETS elements.
  */
 #define MLXSW_REG_QEEC_ID 0x400D
-#define MLXSW_REG_QEEC_LEN 0x1C
+#define MLXSW_REG_QEEC_LEN 0x20
 
 static const struct mlxsw_reg_info mlxsw_reg_qeec = {
 	.id = MLXSW_REG_QEEC_ID,
@@ -1918,6 +1918,15 @@ MLXSW_ITEM32(reg, qeec, element_index, 0x04, 0, 8);
  */
 MLXSW_ITEM32(reg, qeec, next_element_index, 0x08, 0, 8);
 
+/* reg_qeec_mise
+ * Min shaper configuration enable. Enables configuration of the min
+ * shaper on this ETS element
+ * 0 - Disable
+ * 1 - Enable
+ * Access: RW
+ */
+MLXSW_ITEM32(reg, qeec, mise, 0x0C, 31, 1);
+
 enum {
 	MLXSW_REG_QEEC_BYTES_MODE,
 	MLXSW_REG_QEEC_PACKETS_MODE,
@@ -1934,6 +1943,17 @@ enum {
  */
 MLXSW_ITEM32(reg, qeec, pb, 0x0C, 28, 1);
 
+/* The smallest permitted min shaper rate. */
+#define MLXSW_REG_QEEC_MIS_MIN	200000		/* Kbps */
+
+/* reg_qeec_min_shaper_rate
+ * Min shaper information rate.
+ * For CPU port, can only be configured for port hierarchy.
+ * When in bytes mode, value is specified in units of 1000bps.
+ * Access: RW
+ */
+MLXSW_ITEM32(reg, qeec, min_shaper_rate, 0x0C, 0, 28);
+
 /* reg_qeec_mase
  * Max shaper configuration enable. Enables configuration of the max
  * shaper on this ETS element.
-- 
2.20.1


  parent reply	other threads:[~2020-01-16 18:14 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-16 17:30 [PATCH AUTOSEL 4.9 001/251] drm/sti: do not remove the drm_bridge that was never added Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 002/251] drm/virtio: fix bounds check in virtio_gpu_cmd_get_capset() Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 003/251] ALSA: hda: fix unused variable warning Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 004/251] IB/rxe: replace kvfree with vfree Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 005/251] regulator: fixed: Default enable high on DT regulators Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 006/251] ALSA: usb-audio: update quirk for B&W PX to remove microphone Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 007/251] staging: comedi: ni_mio_common: protect register write overflow Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 008/251] pwm: lpss: Release runtime-pm reference from the driver's remove callback Sasha Levin
2020-01-16 17:30 ` Sasha Levin [this message]
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 010/251] pcrypt: use format specifier in kobject_add Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 011/251] exportfs: fix 'passing zero to ERR_PTR()' warning Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 012/251] drm/dp_mst: Skip validating ports during destruction, just ref Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 013/251] net: phy: Fix not to call phy_resume() if PHY is not attached Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 014/251] pinctrl: sh-pfc: r8a7740: Add missing REF125CK pin to gether_gmii group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 015/251] pinctrl: sh-pfc: r8a7740: Add missing LCD0 marks to lcd0_data24_1 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 016/251] pinctrl: sh-pfc: r8a7791: Remove bogus ctrl marks from qspi_data4_b group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 017/251] pinctrl: sh-pfc: r8a7791: Remove bogus marks from vin1_b_data18 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 018/251] pinctrl: sh-pfc: sh73a0: Add missing TO pin to tpu4_to3 group Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 019/251] pinctrl: sh-pfc: r8a7794: Remove bogus IPSR9 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 020/251] pinctrl: sh-pfc: sh7734: Add missing IPSR11 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 021/251] pinctrl: sh-pfc: sh7269: Add missing PCIOR0 field Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 022/251] pinctrl: sh-pfc: sh7734: Remove bogus IPSR10 value Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 023/251] Input: nomadik-ske-keypad - fix a loop timeout test Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 024/251] clk: highbank: fix refcount leak in hb_clk_init() Sasha Levin
2020-01-16 17:30 ` [PATCH AUTOSEL 4.9 025/251] clk: qoriq: fix refcount leak in clockgen_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 026/251] clk: socfpga: fix refcount leak Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 027/251] clk: samsung: exynos4: fix refcount leak in exynos4_get_xom() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 028/251] clk: imx6q: fix refcount leak in imx6q_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 029/251] clk: imx6sx: fix refcount leak in imx6sx_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 030/251] clk: imx7d: fix refcount leak in imx7d_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 031/251] clk: vf610: fix refcount leak in vf610_clocks_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 032/251] clk: armada-370: fix refcount leak in a370_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 033/251] clk: kirkwood: fix refcount leak in kirkwood_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 034/251] clk: armada-xp: fix refcount leak in axp_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 035/251] clk: dove: fix refcount leak in dove_clk_init() Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 036/251] IB/usnic: Fix out of bounds index check in query pkey Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 037/251] RDMA/ocrdma: " Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 038/251] RDMA/qedr: " Sasha Levin
2020-01-16 17:31 ` [PATCH AUTOSEL 4.9 039/251] arm64: dts: apq8016-sbc: Increase load on l11 for SDCARD Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116173445.21385-9-sashal@kernel.org \
    --to=sashal@kernel.org \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=petrm@mellanox.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox