From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FD80C47409 for ; Thu, 16 Jan 2020 17:37:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0CB0D246D5 for ; Thu, 16 Jan 2020 17:37:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196272; bh=xYjH+m2aO9ma/Nyj7HH0ReQJgmMt1kCeRHmxT3MChuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=FCTg7g9R8Mp2tb3nfacyA5ffLwhGOq/+MnsNtV27hlLkgocxVRvjSGs974ntj8rEy 3cnu4YUUfEAdKmwgInp7yhsq1XHQ1xLiKfnOEFOdhxZWHxUwOhs9XAg/UqZBXxyf+F Y/j5jW5+S8XWxfWTc/jTf2TCKc4TXEtTxurJCK8k= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730260AbgAPRhv (ORCPT ); Thu, 16 Jan 2020 12:37:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:52828 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405375AbgAPRha (ORCPT ); Thu, 16 Jan 2020 12:37:30 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 15E71246E5; Thu, 16 Jan 2020 17:37:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579196249; bh=xYjH+m2aO9ma/Nyj7HH0ReQJgmMt1kCeRHmxT3MChuY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vDN7IFdiJtpi0kxCAYAQRKac9Usa+m+BgmVI/J0MY6cmdPAz2UtssaOKfI28c1M9X h47SjG/LG+j+KxL/FKUBWWSLuo862cFg93Y9Gex3lNAPmxkd8/v8lAVBKLOVDGxhe2 hCLK65XoqLPBK+1f5NCbpSJ8y5CjdCSvHQjSohZs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Axel Lin , Mark Brown , Sasha Levin Subject: [PATCH AUTOSEL 4.9 077/251] regulator: pv88080: Fix array out-of-bounds access Date: Thu, 16 Jan 2020 12:33:46 -0500 Message-Id: <20200116173641.22137-37-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116173641.22137-1-sashal@kernel.org> References: <20200116173641.22137-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Axel Lin [ Upstream commit 3c413f594c4f9df40061445667ca11a12bc8ee34 ] Fix off-by-one while iterating current_limits array. The valid index should be 0 ~ n_current_limits -1. Fixes: 99cf3af5e2d5 ("regulator: pv88080: new regulator driver") Signed-off-by: Axel Lin Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/regulator/pv88080-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/pv88080-regulator.c b/drivers/regulator/pv88080-regulator.c index 954a20eeb26f..a40ecfb77210 100644 --- a/drivers/regulator/pv88080-regulator.c +++ b/drivers/regulator/pv88080-regulator.c @@ -279,7 +279,7 @@ static int pv88080_set_current_limit(struct regulator_dev *rdev, int min, int i; /* search for closest to maximum */ - for (i = info->n_current_limits; i >= 0; i--) { + for (i = info->n_current_limits - 1; i >= 0; i--) { if (min <= info->current_limits[i] && max >= info->current_limits[i]) { return regmap_update_bits(rdev->regmap, -- 2.20.1