From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22D1C33CAF for ; Thu, 16 Jan 2020 19:21:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7CE0E2073A for ; Thu, 16 Jan 2020 19:21:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="Fez1PCHq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2437696AbgAPTVA (ORCPT ); Thu, 16 Jan 2020 14:21:00 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:42557 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731179AbgAPTU5 (ORCPT ); Thu, 16 Jan 2020 14:20:57 -0500 Received: by mail-qv1-f68.google.com with SMTP id dc14so9592874qvb.9 for ; Thu, 16 Jan 2020 11:20:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=81kflwq1LKTJoJRd6zHjSIcQI0KmlXkcls9/tBo7nuA=; b=Fez1PCHqieVREo0dLSh28taNzYtPlXRUhitMndvsYDHN1n41rUz0luanpBE0vOj92m LurMdl64dXLzC3uruGzU/xkRJeY7AqQE73PlD2b/ATsdKAnuPIi3tRzVH7o7yVxIQUvQ LoxsiYQGH1au9vFIV754rPw8hKPJTFIblURKLz7ZnV8D0CFZsj4m1BbljlVQJ2t9fUHC YINLzw++UT+xSUxGnuGoYI2Nnyd6Lj/fwgPv+6tCws7oTJH+fltXlTITwh63inMrYFkN hrJaZzEt3eDunOgXw7VfGJ/Ot0SvEdBfvEQQkG+Qg6XCDoMEhxV0/8z9h/4D7rpaG7ES c1Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=81kflwq1LKTJoJRd6zHjSIcQI0KmlXkcls9/tBo7nuA=; b=sCVip7ksaxhCbE/DKEXmoFIpHUbC93o7sZHiFlkNIMzFUEysFZWZYdQxRepuizLRVx 2A4c6khOItT+KuK3R+A8fvqPxA1njs6ihfKMzJOgbI363tjsNEFxyrR7nK/ZUsRbwXHZ A37qbbDI6lUG7qI1rHSbYeRPhDmvRtXOb+u9xQJ9I7PRy6LRA+CST7hFKhMzcmdlOGZv GSg1PlQJzBURQljlBg8aR5J9KYAdEyJys+W2HCpDTnqwDdbqbucT0C+88zLNi0nLXC/a D3mJxRgyIo5kWw6oPXSJGoHKTyCrmFAGDte8APZnrjfp2FHRhzSr+8KJu8hYfhZMoH8V rbmA== X-Gm-Message-State: APjAAAVEyVOMQG08l3nqG7+s7i+OKOS9gsRNeI6XyPBFv3kCSVDVqN6v oEjVCzLlPNSyll6uvwUOYEOBmg== X-Google-Smtp-Source: APXvYqzn+xRkLkCNs33bv/K5N2101y0EqVzvVTH+y2BK05cdkxkk2BDyz6ambGon1fg0n2v/t2jjrQ== X-Received: by 2002:ad4:4e34:: with SMTP id dm20mr4261496qvb.163.1579202456652; Thu, 16 Jan 2020 11:20:56 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id i2sm11820744qte.87.2020.01.16.11.20.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Jan 2020 11:20:55 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1isAhK-0002fJ-Ma; Thu, 16 Jan 2020 15:20:54 -0400 Date: Thu, 16 Jan 2020 15:20:54 -0400 From: Jason Gunthorpe To: rao Shoaib Cc: linux-rdma@vger.kernel.org, monis@mellanox.com, dledford@redhat.com, sean.hefty@intel.com, hal.rosenstock@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 0/2] RDMA/rxe: rxe should use same buffer size for SGE's and inline data Message-ID: <20200116192054.GD10759@ziepe.ca> References: <1579199412-15741-1-git-send-email-rao.shoaib@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1579199412-15741-1-git-send-email-rao.shoaib@oracle.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 16, 2020 at 10:30:10AM -0800, rao Shoaib wrote: > From: Rao Shoaib > > Incorportaed suggestions from Jason. There are two patches. > Patch #1 introduces max WQE size as suggested by Jason > Patch #2 allocates resources requested and makes sure that the buffer size > is same for SG entries and inline data, maximum of the two values > requested is used. > > Rao Shoaib (2): > RDMA/rxe: use RXE_MAX_WQE_SIZE to enforce limits > RDMA/rxe: SGE buffer and max_inline data must have same size I already took v3, with modifications Jason