From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 079F3C33CAF for ; Thu, 16 Jan 2020 23:32:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C624420684 for ; Thu, 16 Jan 2020 23:32:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217558; bh=f96ZAgfD7z4kX6S1UyNF8i0p7VlaogHIyeGDEhekY8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=OS5SPguGlLQip2mpnwrMZw2S7NSsN0L/uKPc0cjPTYpRkTz/a/7lbAguQKHTgZ0fO M5jVmCpNeMrIJppJofiLC/E3ZWtGOzvXviwTVrS1jFmSV4b2GrTOMtl4DZeBl09UXC 0eIdw7B56EPUcNxG39tozeJRixcZL8tQ1x7VZeXw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403883AbgAPXci (ORCPT ); Thu, 16 Jan 2020 18:32:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:41928 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404089AbgAPXc3 (ORCPT ); Thu, 16 Jan 2020 18:32:29 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DF5F206D9; Thu, 16 Jan 2020 23:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217548; bh=f96ZAgfD7z4kX6S1UyNF8i0p7VlaogHIyeGDEhekY8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q3PuFaSPWFqxsRLyRQyUBk2i4IUbUMvytO1YbNCZ1MfNB7ORb08iOfHlzN4u+K/Jm QCkpdfi6u8occE4LxAOjmbUeFIMKJNTCnlUiHVlQtG04dLrg75iv+Et+hG7y0dFvqp X7JpQOAws3umUVOsbVwYb4L9DML5Lttg0RHNuRXw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Geert Uytterhoeven , Linus Walleij Subject: [PATCH 4.14 26/71] gpio: Fix error message on out-of-range GPIO in lookup table Date: Fri, 17 Jan 2020 00:18:24 +0100 Message-Id: <20200116231713.266491730@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231709.377772748@linuxfoundation.org> References: <20200116231709.377772748@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geert Uytterhoeven commit d935bd50dd14a7714cbdba9a76435dbb56edb1ae upstream. When a GPIO offset in a lookup table is out-of-range, the printed error message (1) does not include the actual out-of-range value, and (2) contains an off-by-one error in the upper bound. Avoid user confusion by also printing the actual GPIO offset, and correcting the upper bound of the range. While at it, use "%u" for unsigned int. Sample impact: -requested GPIO 0 is out of range [0..32] for chip e6052000.gpio +requested GPIO 0 (45) is out of range [0..31] for chip e6052000.gpio Fixes: 2a3cf6a3599e9015 ("gpiolib: return -ENOENT if no GPIO mapping exists") Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/20191127095919.4214-1-geert+renesas@glider.be Signed-off-by: Linus Walleij Signed-off-by: Greg Kroah-Hartman --- drivers/gpio/gpiolib.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -3167,8 +3167,9 @@ static struct gpio_desc *gpiod_find(stru if (chip->ngpio <= p->chip_hwnum) { dev_err(dev, - "requested GPIO %d is out of range [0..%d] for chip %s\n", - idx, chip->ngpio, chip->label); + "requested GPIO %u (%u) is out of range [0..%u] for chip %s\n", + idx, p->chip_hwnum, chip->ngpio - 1, + chip->label); return ERR_PTR(-EINVAL); }