From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3705EC33CAF for ; Thu, 16 Jan 2020 23:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E72AE2072E for ; Thu, 16 Jan 2020 23:27:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217265; bh=Cke7DNyivCHaET6d67Yi6A3cYsDbS/GaEgDd5EpDpSI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=o1UmL5kpw9lrZMpdGCJ+HXsQjlmkeMwtvRiEmb2dimV3VFWVsDYYruucC8M3qdpPR GUkuK9pGppdzoeW+l/ByApB2xREJe+nBlLwrC6PGiSe17oJyy6w8Hn7G2gocfHiGDR fmuePoYu+YlA5TLRS7jCUtTglR4MNd5qtzw+85Xc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387515AbgAPX1o (ORCPT ); Thu, 16 Jan 2020 18:27:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:59614 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729401AbgAPX1i (ORCPT ); Thu, 16 Jan 2020 18:27:38 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 08A2620684; Thu, 16 Jan 2020 23:27:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579217257; bh=Cke7DNyivCHaET6d67Yi6A3cYsDbS/GaEgDd5EpDpSI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2V76hrD7hwvQr9lip2zJvrBMjfvE9NncTz81ClcoGJmn6KJv2nAi+T9vBQNFQELmc m0J7ayP7jarT1hPgFIMdknijYl18vNOQW/JvqO/KHMXbBZ4vd2x/b4TLa/sCH/RCCc dvWydMoEKl0AzFXYx+T8qk2XQH+cxXkx04GYWQKM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Fabian Henneke , Jiri Kosina , Sasha Levin Subject: [PATCH 4.19 01/84] hidraw: Return EPOLLOUT from hidraw_poll Date: Fri, 17 Jan 2020 00:17:35 +0100 Message-Id: <20200116231713.375724153@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200116231713.087649517@linuxfoundation.org> References: <20200116231713.087649517@linuxfoundation.org> User-Agent: quilt/0.66 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fabian Henneke [ Upstream commit 378b80370aa1fe50f9c48a3ac8af3e416e73b89f ] Always return EPOLLOUT from hidraw_poll when a device is connected. This is safe since writes are always possible (but will always block). hidraw does not support non-blocking writes and instead always calls blocking backend functions on write requests. Hence, so far, a call to poll never returned EPOLLOUT, which confuses tools like socat. Signed-off-by: Fabian Henneke In-reply-to: Signed-off-by: Jiri Kosina Signed-off-by: Sasha Levin --- drivers/hid/hidraw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hid/hidraw.c b/drivers/hid/hidraw.c index c7cff929b419..c75b66d58636 100644 --- a/drivers/hid/hidraw.c +++ b/drivers/hid/hidraw.c @@ -260,7 +260,7 @@ static __poll_t hidraw_poll(struct file *file, poll_table *wait) poll_wait(file, &list->hidraw->wait, wait); if (list->head != list->tail) - return EPOLLIN | EPOLLRDNORM; + return EPOLLIN | EPOLLRDNORM | EPOLLOUT; if (!list->hidraw->exist) return EPOLLERR | EPOLLHUP; return 0; -- 2.20.1