Re: [PATCH 5.4 140/203] MIPS: PCI: remember nasid changed by set interrupt affinity

Sudip Mukherjee
2020-11-18T21:41:53Z

Hi Greg,

On Fri, Jan 17, 2020 at 12:17:37AM +0100, Greg Kroah-Hartman wrote:
> From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
>
> commit 37640adbefd66491cb8083a438f7bf366ac09bc7 upstream.
>

<snip>

>
> ---
> arch/mips/pci/pci-xtalk-bridge.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> --- a/arch/mips/pci/pci-xtalk-bridge.c
> +++ b/arch/mips/pci/pci-xtalk-bridge.c
> @@ -279,16 +279,15 @@ static int bridge_set_affinity(struct ir
> struct bridge_irq_chip_data *data = d->chip_data;
> int bit = d->parent_data->hwirq;
> int pin = d->hwirq;
> - nasid_t nasid;
> int ret, cpu;
>
> ret = irq_chip_set_affinity_parent(d, mask, force);
> if (ret >= 0) {
> cpu = cpumask_first_and(mask, cpu_online_mask);
> - nasid = COMPACT_TO_NASID_NODEID(cpu_to_node(cpu));
> + data->nnasid = COMPACT_TO_NASID_NODEID(cpu_to_node(cpu));

This will be 'data->nasid' and its causing mips builds to fail.

--
Regards
Sudip