Re: [PATCH 1/1] Return EINVAL when precise_ip perf events are requested on Arm

James Clark
2020-01-17T13:11:32Z

Hi Will,

Yes you're right, I've somehow managed to post a version of the patch
from before I built and tested it.

I will repost it shortly with the other change split out as well.

Thanks
James

On 17/01/2020 13:05, Will Deacon wrote:
>> On Wed, Jan 15, 2020 at 10:58:55AM +0000, James Clark wrote:
>>> diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c
>>> index df352b334ea7..4ddbdb93b3b6 100644
>>> --- a/drivers/perf/arm_pmu.c
>>> +++ b/drivers/perf/arm_pmu.c
>>> @@ -102,6 +102,9 @@ armpmu_map_event(struct perf_event *event,
>>> u64 config = event->attr.config;
>>> int type = event->attr.type;
>>>
>>> + if (event->attr.precise)
>>> + return -EINVAL;
>
> Also, does this field even exist? Guessing you mean 'precise_ip', but
> then that means this hasn't even seen a compiler :(
>
> Will
>