From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7CB5C33CB7 for ; Sat, 18 Jan 2020 14:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FE062469E for ; Sat, 18 Jan 2020 14:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579357339; bh=JrvLwcwKSbaYduAx1j/+g7iO4bO/gKI4RPpGC3Yexg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=LRRTkGQX+2LcyJMO8RdTPvEewhmxw+nYuNcImpi71jZ1kv/3Hj+CFWfX0a/Xle02P 845SMXlC0aBlFdyYD4WTV9JSWNDK+m8zlk9DU5NaG3jkgGiz81kR/s66Ve3QJgl/Fq JWDnJeYe4SekvnfSiGcqyUGxg3So06ldFk8Z8lSQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726490AbgAROWS (ORCPT ); Sat, 18 Jan 2020 09:22:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:48100 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726208AbgAROWS (ORCPT ); Sat, 18 Jan 2020 09:22:18 -0500 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD87A2469A; Sat, 18 Jan 2020 14:22:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579357337; bh=JrvLwcwKSbaYduAx1j/+g7iO4bO/gKI4RPpGC3Yexg0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=2F4p9QMA24NQEzvX8OMBVSJIXSbPlzCAGzcy7QK5fdv+s54Bng2xUXf16+eqBBPak F4JrGFYDJ/Vsq2R+jFQ2rTEUstN43mvE352lpE1zuRvwXNzyJllpx7bvQL1MrpGvzH bfcTjg1H+8ckLLEdj7MCzWokAPBgoAi6Aq+5l65U= Date: Sat, 18 Jan 2020 14:22:12 +0000 From: Jonathan Cameron To: Fabrice Gasnier Cc: , , , , , , , , , , Subject: Re: [PATCH] iio: adc: stm32-adc: don't print an error on probe deferral Message-ID: <20200118142212.55ea44fd@archlinux> In-Reply-To: <1578921539-6353-1-git-send-email-fabrice.gasnier@st.com> References: <1578921539-6353-1-git-send-email-fabrice.gasnier@st.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Jan 2020 14:18:59 +0100 Fabrice Gasnier wrote: > From: Etienne Carriere > > Do not print an error trace when deferring probe for some resource. > > Signed-off-by: Etienne Carriere > Signed-off-by: Fabrice Gasnier Applied. Thanks, Jonathan > --- > drivers/iio/adc/stm32-adc-core.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/stm32-adc-core.c b/drivers/iio/adc/stm32-adc-core.c > index 97655d7..2df88d2 100644 > --- a/drivers/iio/adc/stm32-adc-core.c > +++ b/drivers/iio/adc/stm32-adc-core.c > @@ -688,7 +688,8 @@ static int stm32_adc_probe(struct platform_device *pdev) > priv->vref = devm_regulator_get(&pdev->dev, "vref"); > if (IS_ERR(priv->vref)) { > ret = PTR_ERR(priv->vref); > - dev_err(&pdev->dev, "vref get failed, %d\n", ret); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "vref get failed, %d\n", ret); > return ret; > } > > @@ -696,7 +697,8 @@ static int stm32_adc_probe(struct platform_device *pdev) > if (IS_ERR(priv->aclk)) { > ret = PTR_ERR(priv->aclk); > if (ret != -ENOENT) { > - dev_err(&pdev->dev, "Can't get 'adc' clock\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "Can't get 'adc' clock\n"); > return ret; > } > priv->aclk = NULL; > @@ -706,7 +708,8 @@ static int stm32_adc_probe(struct platform_device *pdev) > if (IS_ERR(priv->bclk)) { > ret = PTR_ERR(priv->bclk); > if (ret != -ENOENT) { > - dev_err(&pdev->dev, "Can't get 'bus' clock\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(&pdev->dev, "Can't get 'bus' clock\n"); > return ret; > } > priv->bclk = NULL;